fix(macro): set the macro release states wait_ms #2357
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
when we create a release trigger state for each press state we miss setting the releases wait_ms field, resulting in key releases all occuring instantaneously this can result in lost key release commands see issue zmkfirmware#2356
|
It might be nice to add a test for this, perhaps? I just noticed it also fails one of the tests anyway, so that would need to be handled. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
when we create a release trigger state for each press state we miss setting the releases wait_ms field, resulting in key releases all occuring instantaneously
this can result in lost key release commands
see issue #2356
logs testing this fix are posted in the linked issue