-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat extra MEH and HYPER combined modifier and copilot key support #2341
base: main
Are you sure you want to change the base?
Conversation
Note that I haven't given this as detailed a look as lesshonor yet, but I have some high level thoughts:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You don't need to close this PR and open a new one to squash commits—rebasing and force pushing is fine. Adhering to conventional commit guidelines is encouraged. (Don't worry about preserving any of the co-author stuff; I don't care.)
ZMK is not an ultra-fast moving project; there are maybe three people with merge permissions (this does not include me). Your patience with discussions and reviews is appreciated. Taking the extra time to carefully audit your proposed changes for any typos and inconsistencies would be productive.
I just want it to be valuable to many people. The best possible naming is important here. Changing it later is painful. I like your naming solutions for the functions. I do understand and respect that some do not see the value of defines for 2 key modifiers. Regarding the concrete example, I do agree too. I initially did not to keep it similar with the rest. Regarding the missing back tick, locally I did not get an error. I did not add the copilot key, initially as I consider it a possible temporary thing. I kept that in my keyboard configuration. What is the best way to squash the commits on the same branch for this case? Not being git fluent. I looked up several options. I converted this pull request to a draft for now. |
73adf40
to
8c6bda2
Compare
I tested on Windows, Linux(KDE) and i tried iOS. I do not have a Mac so I cannot test that. Updated my test branch for zmk-config for a corn-ish zen again: https://github.com/nicenemo/zmk-config/tree/test_custom_modifier_patch_for_zmk_config |
Add left and right combinations of modifiers such as HYPER and MEH.
Adds the copilot key.
Closes #2339
Tested on my Cornish-Zen with https://github.com/nicenemo/zmk-config/tree/test_custom_modifier_patch_for_zmk_config