Add support for the Preonic rev3 board to ZMK #228
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…irmware#202 before it can be tested.
…irmware#202 before it can be tested.
…irmware#202 before it can be tested.
…lly written using the Zephyr macros, when a simple #if !defined() would have sufficed.
petejohanson
requested changes
Oct 5, 2020
| @@ -51,6 +51,7 @@ static int kscan_gpio_config_interrupts(struct device **devices, | |||
| } | |||
| #endif | |||
|
|
|||
|
|
|||
There was a problem hiding this comment.
I'm not sure I follow the question. Can you elaborate?
Add ZMK copyright headers where missing. Add BT_ bindings for testing purposes in keymap.
petejohanson
requested changes
Oct 9, 2020
| // | | | | | | | | | | | | | | ||
| bindings = < | ||
| &kp F1 &kp F2 &kp F3 &kp F4 &kp F5 &kp F6 &kp F7 &kp F8 &kp F9 &kp F10 &kp F11 &kp F12 | ||
| &bt BT_SEL 0 &bt BT_SEL 1 &bt BT_SEL 2 &bt BT_SEL 3 &bt BT_SEL 4 &trans &trans &trans &trans &trans &trans &kp DEL |
There was a problem hiding this comment.
Thanks for adding this... At the same time... There's no way to get to this adjust layer (yet, I'm still brainstorming how best to handle this common pattern). Can we put this on raise instead?
There was a problem hiding this comment.
@shurikai Did you see this comment? TIA.
|
Is this PR dead? |
aumuell
added a commit
to aumuell/zmk
that referenced
this pull request
Aug 11, 2021
My Planck rev 6.1 would not register any keys without "col2row". I also had to apply a matrix_transform in order to move them to the correct position. Peeking into zmkfirmware#228 helped for finding this.
aumuell
added a commit
to aumuell/zmk
that referenced
this pull request
Aug 11, 2021
My Planck rev 6.1 would not register any keys without "col2row". I also had to apply a matrix_transform in order to move them to the correct position. Peeking into zmkfirmware#228 helped for finding this.
Merged
aumuell
added a commit
to aumuell/zmk
that referenced
this pull request
Aug 23, 2021
My Planck rev 6.1 would not register any keys without "col2row". I also had to apply a matrix_transform in order to move them to the correct position. Peeking into zmkfirmware#228 helped for finding this. I also add transforms for the 2u spacebar layouts.
petejohanson
pushed a commit
that referenced
this pull request
Aug 25, 2021
My Planck rev 6.1 would not register any keys without "col2row". I also had to apply a matrix_transform in order to move them to the correct position. Peeking into #228 helped for finding this. I also add transforms for the 2u spacebar layouts.
ivandaho
pushed a commit
to ivandaho/zmk
that referenced
this pull request
Oct 21, 2021
My Planck rev 6.1 would not register any keys without "col2row". I also had to apply a matrix_transform in order to move them to the correct position. Peeking into zmkfirmware#228 helped for finding this. I also add transforms for the 2u spacebar layouts.
fsargent
pushed a commit
to fsargent/zmk
that referenced
this pull request
Nov 19, 2021
My Planck rev 6.1 would not register any keys without "col2row". I also had to apply a matrix_transform in order to move them to the correct position. Peeking into zmkfirmware#228 helped for finding this. I also add transforms for the 2u spacebar layouts.
Luberry
pushed a commit
to Luberry/zmk
that referenced
this pull request
Nov 30, 2021
My Planck rev 6.1 would not register any keys without "col2row". I also had to apply a matrix_transform in order to move them to the correct position. Peeking into zmkfirmware#228 helped for finding this. I also add transforms for the 2u spacebar layouts.
PedroDiogo
pushed a commit
to PedroDiogo/zmk
that referenced
this pull request
Feb 7, 2022
My Planck rev 6.1 would not register any keys without "col2row". I also had to apply a matrix_transform in order to move them to the correct position. Peeking into zmkfirmware#228 helped for finding this. I also add transforms for the 2u spacebar layouts.
bromanko
pushed a commit
to bromanko/zmk
that referenced
this pull request
Feb 25, 2022
My Planck rev 6.1 would not register any keys without "col2row". I also had to apply a matrix_transform in order to move them to the correct position. Peeking into zmkfirmware#228 helped for finding this. I also add transforms for the 2u spacebar layouts.
|
@shurikai If still interested in getting this in, can you please see the one comment, and add a ZMK metadata file, so we can get this merged? Closing for now, but feel free to reopen. |
tyalie
pushed a commit
to tyalie/zmk
that referenced
this pull request
Nov 15, 2022
My Planck rev 6.1 would not register any keys without "col2row". I also had to apply a matrix_transform in order to move them to the correct position. Peeking into zmkfirmware#228 helped for finding this. I also add transforms for the 2u spacebar layouts.
NikolaRavic
pushed a commit
to NikolaRavic/zmk-firmware
that referenced
this pull request
Feb 27, 2023
My Planck rev 6.1 would not register any keys without "col2row". I also had to apply a matrix_transform in order to move them to the correct position. Peeking into zmkfirmware#228 helped for finding this. I also add transforms for the 2u spacebar layouts.
yuanbin
pushed a commit
to yuanbin/zmk
that referenced
this pull request
Jun 14, 2023
My Planck rev 6.1 would not register any keys without "col2row". I also had to apply a matrix_transform in order to move them to the correct position. Peeking into zmkfirmware#228 helped for finding this. I also add transforms for the 2u spacebar layouts.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request is to add support for the Preonic rev 3. The preonic is a board with built in MCU, and not a shield. The included default keymap is based on the one found on the QMK configurator, but will not be fully functional until shifted keycodes are available.
To build:
west build -b preonic_rev3Note that there is one file touched below (kscan_gpio_matrix.c) that was strictly a change to line formatting in the C file. Nothing changed functionally.