Skip dropping request on code request parameter #529
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By default if someone makes a GET /?code= as request parameter `&code=...` error `request to the redirect_uri path but there's no session state found` will be raised.
I believe that it's related to
```
local function openidc_get_path(uri)
local without_query = uri:match("(.-)%?") or uri
return without_query:match(".-//[^/]+(/.*)") or without_query
end
```
Where basically &code matches the regex which triggers authorization response from OP.
`&code=` alone without extra request parameter should be treated as authorization response ?
Eventough I don't believe that this is a viable solution
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By default if someone makes a GET request with parameter
&code=...after authentication against IdPclassic error
request to the redirect_uri path but there's no session state foundwill be raised.I believe that it's related to
Where basically &code matches the regex which triggers authorization response from OP.
&code=alone without extra request parameter should be treated as authorization response ?Eventough I don't believe that this is a viable solution but the issue seems to be present