remove masking of s7 protocols errors #322
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This MR removes the masking of errors for the siemens s7 protocol scanner.
The current behaviour:
The scan is marked as a success when no information is returned.
The updated behaviour:
How to Test
echo $IP | ./zgrab2 siemens
Notes & Caveats
The S7 protocol scanner currently masks errors and will silently fail if a host responds with a ISO 8327-1 "Abort" packet. The scan will be incorrectly marked as a false positive.