Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

preserve protocols order, specified in ini file for multiple mode #243

Merged
merged 2 commits into from
Jun 6, 2021

Conversation

Meteorite
Copy link
Contributor

Update zflags module to new version, that preserves ini file sections order, so protocols will be probed in order, specified in ini config file for multiple mode.

It is especially useful when break-on-success flag is used to specify protocols probe order and try more popular protocols first.

How to Test

Set at least 2 different protocols in multiple mode configuration file with the same port, e.g. ssh and http:

...
[ssh]
port=80
[http]
port=80

Run multiple mode with break-on-success option on host, having http server on specified port, e.g. icanhazip.com. Make sure both ssh and http were tried.

Then invert protocols order in ini file:

...
[http]
port=80
[ssh]
port=80

and run multiple mode with break-on-success option again. Make sure only http but not ssh was tried.

@zakird zakird merged commit 2b6e6cb into zmap:master Jun 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants