Use a binned histogram by dump size to compute incremental estimates. #59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zmanda-pusher1
force-pushed
the
master
branch
2 times, most recently
from
4135368
to
b25ad61
Compare
|
This looks interesting and with a later review may be good to bring in. Estimation, with no crashes, is always ripe for fiddling. I'll ask around for some opinions too after I review it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Speaking of better estimates:
The compression rate on incremental backups tends to vary heavily based
on the size of the incremental. This method computes the compression
rate much better by only basing the average on similar sizes from the
past.