avoid Promise.resolve in the main Promise feature detection

zloirock · May 3, 2021 · afc66bc · afc66bc
1 parent 5623fa3
commit afc66bc
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 5 deletions.
diff --git a/packages/core-js/modules/es.promise.js b/packages/core-js/modules/es.promise.js
@@ -65,7 +65,7 @@ var FORCED = isForced(PROMISE, function () {
   // https://github.com/zloirock/core-js/issues/679
   if (V8_VERSION >= 51 && /native code/.test(PromiseConstructor)) return false;
   // Detect correctness of subclassing with @@species support
-  var promise = PromiseConstructor.resolve(1);
+  var promise = new PromiseConstructor(function (resolve) { resolve(1); });
   var FakePromise = function (exec) {
     exec(function () { /* empty */ }, function () { /* empty */ });
   };

diff --git a/tests/compat/tests.js b/tests/compat/tests.js
@@ -33,15 +33,15 @@ var DESCRIPTORS_SUPPORT = function () {
 };
 
 var PROMISES_SUPPORT = function () {
-  var promise = Promise.resolve(1);
+  var promise = new Promise(function (resolve) { resolve(1); });
   var empty = function () { /* empty */ };
   var FakePromise = (promise.constructor = {})[Symbol.species] = function (exec) {
     exec(empty, empty);
   };
 
-  return (IS_NODE || typeof PromiseRejectionEvent == 'function')
-    && promise.then(empty) instanceof FakePromise
-    && V8_VERSION !== 66;
+  return promise.then(empty) instanceof FakePromise
+    && V8_VERSION !== 66
+    && (IS_NODE || typeof PromiseRejectionEvent == 'function');
 };
 
 var SYMBOLS_SUPPORT = function () {