update chart api version so that helm lint works with helm 3 fixes #2 #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rawlingsj
added a commit
to jenkins-x/jx
that referenced
this pull request
Feb 24, 2020
jstrachan
pushed a commit
to jenkins-x/jx
that referenced
this pull request
Feb 26, 2020
jstrachan
pushed a commit
to jenkins-x/jx
that referenced
this pull request
Feb 27, 2020
jstrachan
pushed a commit
to jenkins-x/jx
that referenced
this pull request
Mar 5, 2020
|
Sorry, I missed this PR. This project was meant for helm3 based deployments only so consider it merged. |
rawlingsj
added a commit
to jenkins-x/jx
that referenced
this pull request
Apr 17, 2020
rawlingsj
added a commit
to jenkins-x/jx
that referenced
this pull request
Jun 22, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I guess this PR would cause issues if merged for folks that use helm lint with helm 2. Would it be possible to use git tags to help handle working with different api versions?