Gameboy changes #341
Gameboy changes #341
Conversation
| ._03 dw func_002_6820 | ||
|
|
||
| func_002_681B:: | ||
| ld hl, $9D8F ; $681B: $21 $8F $9D |
There was a problem hiding this comment.
These might be pointers?
| @@ -255,4 +255,4 @@ dw IndoorsBFB ; $2FCE9 | |||
| dw IndoorsBFC ; $2FD1C | |||
| dw IndoorsBFD ; $2FD88 | |||
| dw IndoorsBFE ; $2FDCA | |||
| dw $7E01 ; Invalid room pointer | |||
| dw $7DD7 ; Invalid room pointer | |||
There was a problem hiding this comment.
Probably still points to something, considering it changed between versions
There was a problem hiding this comment.
I think it just points after IndoorsBFE, but there is not more data there for an actual room.
|
Apart from resolving all the merge conflicts (which will probably be a big undertaking in itself), what's the status on this work? How was it done? I'd be interested in helping, but I'm not sure how! |
| @@ -532,9 +488,9 @@ FileCreationInteractiveHandler:: | |||
| ld e, [hl] | |||
| ld hl, $DB80 | |||
| add hl, de | |||
| ld e, l | |||
| ld d, h | |||
| ld bc, $984A | |||
There was a problem hiding this comment.
This should probably be a pointer.
There was a problem hiding this comment.
Yup, these should all be pointers. They point to tile memory in VRAM though, so I'm not sure how best to handle them: we can write ld bc, vTileset1 + $04A, but the offset is still going to change when moving from DMG to GBC code, right?
|
|
||
| func_002_6837:: | ||
| ld hl, $9D0B ; $6837: $21 $0B $9D | ||
| ld hl, $9d2a ; $6837: $21 $0B $9D |
There was a problem hiding this comment.
Another pointer?
| jr jr_002_683F ; $683A: $18 $03 | ||
|
|
||
| func_002_683C:: | ||
| ld hl, $9CEB ; $683C: $21 $EB $9C | ||
| ld hl, $9d2a |
There was a problem hiding this comment.
Another pointer?
| jr_002_683F: | ||
| ld e, $00 ; $683F: $1E $00 | ||
| jr jr_002_6848 ; $6841: $18 $05 | ||
|
|
||
| CopyDungeonMinimapPalette:: | ||
| ld hl, $9D8B ; $6843: $21 $8B $9D | ||
| ld hl, $9daa ; $6843: $21 $8B $9D |
No description provided.