Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ZK-4960: Listbox doesn't keep scrollbar position when applying hflex=… #3230

Merged
merged 1 commit into from
Nov 5, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions zkdoc/release-note
Original file line number Diff line number Diff line change
Expand Up @@ -46,6 +46,7 @@ ZK 10.1.0
ZK-4964: combobox input should be focused while clicking the drop-down button in Android
ZK-5825: Clicking bandbox button on Android does not focus input
ZK-5833: ZK-423 regression on Android
ZK-4960: Listbox doesn't keep scrollbar position when applying hflex="min" on a listheader in mobile

* Upgrade Notes
+ Remove Htmls.encodeJavaScript(), Strings.encodeJavaScript(), Strings.escape() with Strings.ESCAPE_JAVASCRIPT, and replace them with OWASP Java Encoder APIs instead.
Expand Down
2 changes: 1 addition & 1 deletion zul/src/main/resources/web/js/zul/mesh/HeadWidget.ts
Original file line number Diff line number Diff line change
Expand Up @@ -392,7 +392,7 @@ export class HeadWidget extends zul.Widget<HTMLTableRowElement> {
wgt._calcSize(); // yes, we need to do it again.
}
// ZK-2551: need to restore scroll pos after flexs are fixed
if (zk(ebody).hasHScroll() && currentLeft != ebody.scrollLeft) {
if (ebody.scrollWidth > ebody.clientWidth && currentLeft != ebody.scrollLeft) {
ebody.scrollLeft = currentLeft;
if (ehead)
ehead.scrollLeft = currentLeft;
Expand Down
Loading