Skip to content

Make pairing and groth16 optional 🎉#25

Closed
str4d wants to merge 4 commits into
zkcrypto:masterfrom
str4d:ff
Closed

Make pairing and groth16 optional 🎉#25
str4d wants to merge 4 commits into
zkcrypto:masterfrom
str4d:ff

Conversation

@str4d
Copy link
Copy Markdown
Member

@str4d str4d commented Jul 2, 2018 •
edited
Loading

Depends on zkcrypto/pairing#91

@str4d str4d changed the title Use ff crate for Field traits Use ff and group crates for Field and curve traits Jul 6, 2018
@str4d str4d changed the title Use ff and group crates for Field and curve traits Make pairing and groth16 optional 🎉 Jul 6, 2018
@str4d str4d mentioned this pull request Nov 10, 2018
Merged
Eirik0
Eirik0 approved these changes Feb 7, 2019
View reviewed changes
Copy link
Copy Markdown

@Eirik0 Eirik0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

Eirik0
Eirik0 reviewed Feb 7, 2019
View reviewed changes
Comment thread Cargo.toml
byteorder = "1"

[dependencies.pairing]
git = "https://github.com/str4d/pairing"
Copy link
Copy Markdown

@Eirik0 Eirik0 Feb 7, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the idea that this will change back once zkcrypto/pairing#91 has been merged?

Copy link
Copy Markdown
Member Author

@str4d str4d Apr 11, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, that is what happened.

@str4d
Copy link
Copy Markdown
Member Author

str4d commented Apr 11, 2019

This was pulled into bellman in zcash/librustzcash#46 and will be upstreamed back to this repository once the bellman refactor (part of zcash/librustzcash#41) is complete.

@str4d str4d closed this Apr 11, 2019
@str4d str4d mentioned this pull request Apr 11, 2019
Closed
str4d pushed a commit that referenced this pull request Aug 25, 2020
@bmerge
Auto merge of #26 - ebfull:even-more-adjustments, r=ebfull
d72929f 
Even more adjustments

Closes #22
Closes #24
Closes #25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@Eirik0 Eirik0 Eirik0 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@str4d @Eirik0