This repository has been archived by the owner on Jul 6, 2019. It is now read-only.
Update dependencies with security issues #211
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To help understanding why tests fail. Will be visible when run as
env TAP_DEBUG=1 npm run test
"en" is not a universal locale, while "C" is present on absolutely any unix related operating system because it is mandated by POSIX (http://pubs.opengroup.org/onlinepubs/009695399/basedefs/xbd_chap07.html, http://pubs.opengroup.org/onlinepubs/7908799/xbd/locale.html). With "en" three of the tests fail on my machine ..stderr: /bin/sh: warning: setlocale: LC_ALL: cannot change locale (en): No such file or directory ..stderr: /bin/sh: warning: setlocale: LC_ALL: cannot change locale (en): No such file or directory ..stderr: /bin/sh: warning: setlocale: LC_ALL: cannot change locale (en): No such file or directory The locales/C.json file was generated automatically by something while running tests so I assume it is required. The generated file had the same content but slightly different order of the lines, so I rather overwrote with en.json.
Suggested command from npm audit
npm install --save-dev [email protected]
Relevant breaking changes mentioned at
https://github.com/istanbuljs/nyc/blob/master/CHANGELOG.md:
12.0.0 - Drops Node.js 4 support
https://nodesecurity.io/advisories/157
https://nodesecurity.io/advisories/577
Suggested command from npm audit
npm install --save-dev [email protected]
No relevant breaking changes mentioned at
https://www.node-tap.org/changelog/.
https://nodesecurity.io/advisories/157
https://nodesecurity.io/advisories/566
https://nodesecurity.io/advisories/577
https://nodesecurity.io/advisories/598
https://nodesecurity.io/advisories/606
https://nodesecurity.io/advisories/664
Suggested command from npm audit
npm install --save-dev [email protected]
No relevant breaking changes mentioned at
https://github.com/npm/cli/blob/latest/CHANGELOG.md.
https://nodesecurity.io/advisories/565
https://nodesecurity.io/advisories/566
https://nodesecurity.io/advisories/577
https://nodesecurity.io/advisories/593
https://nodesecurity.io/advisories/606
https://nodesecurity.io/advisories/607
https://nodesecurity.io/advisories/612
https://nodesecurity.io/advisories/664
https://nodesecurity.io/advisories/720
|
The build failure with node.js version 6 is unrelated, I created an issue for that. |
|
Is there anything that stops this from being merged? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Running
npm auditon the branchlatestas of writing this givesThis pull request fixes those by updating the applicable dependencies.