Add replace tabs with spaces option #82
Merged
+177
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zkat
requested changes
Oct 4, 2021
README.md
Outdated
| @@ -389,6 +389,7 @@ miette::set_hook(Box::new(|_| { | |||
| .terminal_links(true) | |||
| .unicode(false) | |||
| .context_lines(3) | |||
| .with_tab_width(4) | |||
src/handlers/graphical.rs
Outdated
| } | ||
| } | ||
|
|
||
| /// Replace tabs with spaces. | ||
| pub fn with_tab_width(mut self, width: usize) -> Self { |
There was a problem hiding this comment.
You need to expose .tab_width() through MietteHandler, too, since that's the recommended way of customizing your handler in general.
| @@ -30,7 +30,6 @@ impl miette::ReportHandler for LocationHandler { | |||
| } | |||
|
|
|||
| fn track_caller(&mut self, location: &'static Location<'static>) { | |||
| dbg!(location); | |||
dswij
reviewed
Oct 4, 2021
| @@ -25,6 +25,7 @@ pub struct GraphicalReportHandler { | |||
| pub(crate) theme: GraphicalTheme, | |||
| pub(crate) footer: Option<String>, | |||
| pub(crate) context_lines: usize, | |||
| pub(crate) tab_width: Option<usize>, | |||
There was a problem hiding this comment.
This might sound dumb, but I wonder if a user should be allowed to use tab_width = 0 for no space or it'd rather be better if tab_width = 0 means using tabs 🤔
zkat
approved these changes
Oct 4, 2021
zkat
pushed a commit
that referenced
this pull request
Oct 6, 2021
zkat
pushed a commit
that referenced
this pull request
Oct 6, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #73
Makes it possible to replace tabs with spaces. This is needed because highlight line renderers are not aware of displayed tab width and appear in wrong places if line contains tabs.