Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(fancy): Add option to change the link display texts #335

Merged
merged 1 commit into from
Feb 5, 2024

Conversation

calavera
Copy link
Contributor

@calavera calavera commented Feb 4, 2024

This option allows to globally change the default (link) display text with any other text provider by users.

I investigated if it was possible to change the display text per error, but I was not sold of any option I tried. I think this is a pretty simple addition that can help people like me that just want to change this text for all the errors.

Fixes #331

This option allows to globally change the default `(link)` display text with any other text provider by users.
@calavera
Copy link
Contributor Author

calavera commented Feb 4, 2024

The two failing tests also fail in main. I don't know what they're about.

 failures:
    non_adjacent_highlight
    triple_adjacent_highlight

@zkat zkat merged commit c7144ee into zkat:main Feb 5, 2024
4 of 14 checks passed
@zkat
Copy link
Owner

zkat commented Feb 5, 2024

They're minor issues--miette is outputting whitespace before the newline but autoformatting editors (like mine) remove trailing whitespace, so the strings end up not exactly matching. There's no actual problem. Merged :)

@calavera calavera deleted the link_display_text branch February 5, 2024 18:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change link label to something else
2 participants