Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump terminal-size to v0.3.0 #308

Merged
merged 1 commit into from
Feb 4, 2024
Merged

Bump terminal-size to v0.3.0 #308

merged 1 commit into from
Feb 4, 2024

Conversation

notgull
Copy link
Contributor

@notgull notgull commented Oct 21, 2023

No description provided.

Signed-off-by: John Nunley <[email protected]>
@zkat
Copy link
Owner

zkat commented Oct 23, 2023

is there a reason for this change? It looks like making it will require bumping the MSRV

@notgull
Copy link
Contributor Author

notgull commented Oct 23, 2023

The new version of terminal-size uses rustix instead of libc, empowering it to use direct system calls on Linux and avoid linking to the C standard library. In addition, v1.63.0 is the version of Rust used by Debian Stable.

@notgull
Copy link
Contributor Author

notgull commented Oct 28, 2023

@zkat I can bump the MSRV in this PR if need be.

@notgull
Copy link
Contributor Author

notgull commented Nov 6, 2023

@zkat Any updates on this PR?

@zkat
Copy link
Owner

zkat commented Nov 6, 2023

Nothing new here--I'm going to sit on it until I think we're at a point where it's ok to do a semver-major bump on miette, because I only bump the MSRV with a major bump.

@zkat zkat added the breaking A semver-major breaking change label Nov 15, 2023
@zkat
Copy link
Owner

zkat commented Feb 4, 2024

It is time!

@zkat zkat merged commit c0a298e into zkat:main Feb 4, 2024
8 of 11 checks passed
@notgull notgull deleted the bump-ts branch February 4, 2024 03:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking A semver-major breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants