Add serde support
#264
Add serde support
#264
Conversation
|
Implements #260 |
| /// The total length of the span. Think of this as an offset from `start`. | ||
| length: SourceOffset, | ||
| /// The total length of the span | ||
| length: usize, | ||
| } | ||
|
|
||
| impl SourceSpan { | ||
| /// Create a new [`SourceSpan`]. | ||
| pub fn new(start: SourceOffset, length: SourceOffset) -> Self { |
There was a problem hiding this comment.
It should be:
| pub fn new(start: SourceOffset, length: SourceOffset) -> Self { | |
| pub fn new(start: SourceOffset, length: usize) -> Self { |
But will be breaking change.
SourceOffset may not represent length in no way. This looks more like a range (e.g 3..3)
There was a problem hiding this comment.
Can you make a pr for this once this lands? I'll mark it as breaking but that way we won't forget to do it.
There's a good chunk of desirable breaking changes in the pipeline right now and I think I'm gonna find some time to roll up 6.0 at some point.
|
Looks like you need to fix a conflict, but also I'm not sure about those other dependencies you bumped? Those seem to be what's causing the CI issues |
|
Also you may as well add serde support to MietteDiagnostic while you're at it |
|
Why do you need to update those dependencies? |
|
I don't need to :) Just noticed they are outdated and thought it may be easy to fix it |
This reverts commit f2ef757.
Need to add serde to
MietteDiagnostictoo, when #262 is merged