Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix asref diagnostic macro call #173

Closed
wants to merge 2 commits into from
Closed

Fix asref diagnostic macro call #173

wants to merge 2 commits into from

Conversation

matthiasbeyer
Copy link
Contributor

Closes #172

I would like to ask @TheNeikos for review as well here, as #165 was developed with them.

@matthiasbeyer matthiasbeyer force-pushed the fix-asref-diagnostic-macro-call branch from e42bed4 to c41c842 Compare May 13, 2022 06:11
@matthiasbeyer
Copy link
Contributor Author

This is done way better with #169 IMO. I guess this one should be closed in favour of #169!

@matthiasbeyer
Copy link
Contributor Author

Maybe 0b32574 can be added to #169, so the error from #172 is covered there explicitely as well.

@zkat
Copy link
Owner

zkat commented May 13, 2022

Closing in favor of #169 which I just merged :)

@zkat zkat closed this May 13, 2022
@matthiasbeyer matthiasbeyer deleted the fix-asref-diagnostic-macro-call branch May 13, 2022 19:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Wrapping other Errors without losing diagnostics
2 participants
@matthiasbeyer @zkat