Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: set correct field in MietteHandlerOpts::ansi_colors #150

Merged
merged 1 commit into from
Apr 14, 2022

Commits on Apr 14, 2022

  1. fix: set correct field in MietteHandlerOpts::ansi_colors

    Thanks for miette! We've been having a great time using it in
    cargo-nextest to print out nicely-formatted errors.
    
    I noticed a bug while testing out miette -- the `ansi_colors` method
    does not set ANSI colors properly.
    
    By the way, I do not believe miette should use RGB colors at all --
    default colors in applications must be restricted to 12 ANSI colors. See
    https://rust-cli-recommendations.sunshowers.io/colors.html#color-palettes
    for why. I'm happy to disable RGB colors in all the applications I
    maintain, but doing so globally is something for upstream to consider.
    sunshowers committed Apr 14, 2022
    Configuration menu
    Copy the full SHA
    f2ebc16 View commit details
    Browse the repository at this point in the history