fix(lsp): fix trigger completion of zk LSP #397
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit introduces trigger completion: until now zk LSP generated completion only on auto trigger.
|
Nice, thanks for the PR. On first sight it looks good, but I'll take a closer look in the next days and also want to test it. |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit introduces trigger completion: until now zk LSP generated completion only on auto trigger. In particular this fixes zk-org/zk-nvim#155
The completion bugs came from three sources: there was a wrong implementation of tag completion which forgot to ignore the '#' character, the completion function never made a call for trigger completion, and offset for
textEditon link completion was hardcoded to-2which is wrong if there is an additional text entered before a trigger is pressed. This commit fixes these three bugs.