tesh test case for yaml dates without time stamp #385
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a test case for #382 which found that dates without time
stamps in yaml frontmatter were causing the respective note to be returned when
quering the day before the note creation.
The test case was tested against commit 55d5487, which was before this
bug was resolved: the test failed (the note from 24th of Jan was returned when querying
for notes created on the 23rd of jan)
Ran again against the current commit (post #382 being resolved) and it
passes.
Also, in contributing.md, mickael wrote that it's good practice that we make a test fixture per issue with tesh tests.
But there was already a tests/markdown-yaml-frontmatter.tesh file.
Should I instead add this new test coverage to that test fixture?