LSP: Fix Double Use of notebook.RelPath #246
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mickael-menu
approved these changes
Jul 15, 2022
There was a problem hiding this comment.
@bibor Thanks for spotting and fixing this!
Time to get started with automated tests on the LSP server...
mickael-menu
force-pushed
the
bibor/fix-lsp-ref
branch
from
df7cf39 to
4a29bc1
Compare
|
I amended your commit without change, somehow GitHub actions were stuck. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solves a bug introduced in PR #245. Discussion in #243.
notebook.RelPath() is called on a already relative path from the root. This causes a new, wrong relative path, because it is calculated from the note's paths.