Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Notes with broken relative paths are excluded from operations #78

Closed
chris-sanders opened this issue Sep 13, 2021 · 4 comments · Fixed by #80
Closed

Notes with broken relative paths are excluded from operations #78

chris-sanders opened this issue Sep 13, 2021 · 4 comments · Fixed by #80
Labels
bug Something isn't working

Comments

@chris-sanders
Copy link

chris-sanders commented Sep 13, 2021

I've been rearranging some notes so I can use emanote and zk together and I think I've found a bug in the link validation. I'm moving notes found in a subfolder into the root so I can avoid path mismatches. Notes in the subfolder which references relative paths ex: [This is a link](../my-note.md) once moved to the root aren't included in results anymore.

It took me a while to notice because the warning displays after you return from the list command, and is shown on the previous command prompt. Maybe this is intended, but I didn't expect broken links to prevent finding the note, I was intending to first move files and then fix links and was finding that nothing that I moved was 'present' anymore. In fact, it would be super nice if 'invalid link' were a search term that I could look for mistakes and edit them.

@mickael-menu
Copy link
Member

That's definitely a bug, I think a simple content warning should not prevent the note from being imported.

@mickael-menu
Copy link
Member

Fixed in main, I have a few other things to tackle before the next release.

@chris-sanders
Copy link
Author

chris-sanders commented Sep 13, 2021 via email

@chris-sanders
Copy link
Author

Yup just recompiled and tested, all works as expected.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants