Skip to content

chore(merkle-trees)!: update to match Noir 0.30.0#7

Merged
signorecello merged 1 commit intomainfrom
zpedro/update_0.30.0
Jul 10, 2024
Merged

chore(merkle-trees)!: update to match Noir 0.30.0#7
signorecello merged 1 commit intomainfrom
zpedro/update_0.30.0

Conversation

@signorecello
Copy link
Collaborator

Description

This change updates the MT library to match Noir 0.30.0. The relevant changes were related with the removal of the _as_slice methods as per this PR

I reckon the solution isn't the most elegant, but time is of the essence in this particular situation and I understand this could definitely be iterated later on

@signorecello signorecello requested review from cedoor and sripwoud July 10, 2024 11:15
Copy link
Contributor

@cedoor cedoor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

I still have to study Noir, so I haven't gone into deep, but LGTM!

There are some errors in the CI workflows tho!

@signorecello signorecello force-pushed the zpedro/update_0.30.0 branch from 185a057 to f6e3939 Compare July 10, 2024 13:16
@signorecello signorecello force-pushed the zpedro/update_0.30.0 branch from f6e3939 to d546dd4 Compare July 10, 2024 13:48
@signorecello signorecello merged commit 537b2ad into main Jul 10, 2024
@signorecello signorecello deleted the zpedro/update_0.30.0 branch July 10, 2024 13:51
@signorecello signorecello restored the zpedro/update_0.30.0 branch July 11, 2024 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants