Merge remote-tracking branch 'giteaofficial/main'

* giteaofficial/main:
  Add download attribute to release attachments (go-gitea#28739)
  Concatenate error in `checkIfPRContentChanged` (go-gitea#28731)

services/pull/pull.go

@@ -4,6 +4,7 @@
 package pull
 
 import (
+	"bytes"
 	"context"
 	"fmt"
 	"io"
@@ -422,9 +423,11 @@ func checkIfPRContentChanged(ctx context.Context, pr *issues_model.PullRequest,
 		return false, fmt.Errorf("unable to open pipe for to run diff: %w", err)
 	}
 
+	stderr := new(bytes.Buffer)
 	if err := cmd.Run(&git.RunOpts{
 		Dir:    prCtx.tmpBasePath,
 		Stdout: stdoutWriter,
+		Stderr: stderr,
 		PipelineFunc: func(ctx context.Context, cancel context.CancelFunc) error {
 			_ = stdoutWriter.Close()
 			defer func() {
@@ -436,6 +439,7 @@ func checkIfPRContentChanged(ctx context.Context, pr *issues_model.PullRequest,
 		if err == util.ErrNotEmpty {
 			return true, nil
 		}
+		err = git.ConcatenateError(err, stderr.String())
 
 		log.Error("Unable to run diff on %s %s %s in tempRepo for PR[%d]%s/%s...%s/%s: Error: %v",
 			newCommitID, oldCommitID, base,

templates/repo/release/list.tmpl

@@ -94,7 +94,7 @@
 									{{if .Attachments}}
 										{{range .Attachments}}
 											<li>
-												<a target="_blank" rel="nofollow" href="{{.DownloadURL}}">
+												<a target="_blank" rel="nofollow" href="{{.DownloadURL}}" download>
 													<strong>{{svg "octicon-package" 16 "gt-mr-2"}}{{.Name}}</strong>
 												</a>
 												<div>