Skip to content

Conversation

@hsuanxyz
Copy link

What is this PR for?

A few sentences describing the overall goals of the pull request's commits.
First time? Check out the contributing guide - https://zeppelin.apache.org/contribution/contributions.html

What type of PR is it?

[Feature]

Todos

  • - Task

What is the Jira issue?

How should this be tested?

Screenshots (if appropriate)

Questions:

  • Does the licenses files need update?
  • Is there breaking changes for older versions?
  • Does this needs documentation?

zjffdu and others added 2 commits December 13, 2018 16:44
@zjffdu zjffdu force-pushed the flink_poc branch 3 times, most recently from 0c17f3b to b204c10 Compare December 21, 2018 12:32
@hsuanxyz hsuanxyz closed this Dec 25, 2018
zjffdu pushed a commit that referenced this pull request Mar 29, 2019
### What is this PR for?
This PR fixes the issue of newlines and tabs breaking results in the SQL interpreter in Livy.

The Livy interpreter will return incorrect results if a row contains \n or \t characters.
In the case of the newline, the result will be:
Line is missing from results if the \n appears anywhere but the end of a cell
`String index out of range: 17` if it appears at the end of a cell
In the case of the tab, the result will be misaligned columns if the tab appears in the middle of a cell
The output showing these error is attached to the Jira.

I have changed the parsing and any newline or tab characters will be escaped

### What type of PR is it?
Bug Fix

### What is the Jira issue?
https://issues.apache.org/jira/browse/ZEPPELIN-3098

### How should this be tested?
Unittests have been added

### Screenshots (if appropriate)

### Questions:
* Does the licenses files need update? No
* Is there breaking changes for older versions? No
* Does this needs documentation? No

Author: Alex Bush <[email protected]>
Author: Alex Bush <[email protected]>

Closes apache#2701 from bushnoh/zeppelin-3098 and squashes the following commits:

9f2f6e3 [Alex Bush] Merge pull request #3 from apache/master
14e120d [Alex Bush] Merge pull request #2 from apache/master
46981fd [Alex Bush] Merge pull request #1 from apache/master
ee5a41b [Alex Bush] Merge remote-tracking branch 'upstream/master'
67a93b5 [Alex Bush] Merge branch 'master' of https://github.com/bushnoh/zeppelin
31cdbdc [Alex Bush] Added another comment explaining the regexp change
d054af0 [Alex Bush] Force a dummy change for Travis
64a42be [Alex Bush] Fix for newline and tab in data
zjffdu pushed a commit that referenced this pull request Oct 16, 2020
…Spark Interpreter Scala REPL and fix the CI failure due to low Scala version

### What is this PR for?
- fix the [CI failure](https://travis-ci.org/github/apache/zeppelin/builds/709913046) due to [PR-3852](apache#3852)

### What type of PR is it?
[Bug Fix]

### Todos
* [ ] - Task

### What is the Jira issue?
* [ZEPPELIN-4962](https://issues.apache.org/jira/projects/ZEPPELIN/issues/ZEPPELIN-4962)

### How should this be tested?
* CI test

### Screenshots (if appropriate)

### Questions:
* Does the licenses files need update? NO
* Is there breaking changes for older versions? NO
* Does this needs documentation? Yes

Author: xiejiajun <[email protected]>
Author: xie-jia-jun <[email protected]>
Author: JakeXie <[email protected]>

Closes apache#3860 from xiejiajun/ZEPPELIN-4962 and squashes the following commits:

9128c9b [JakeXie] spark.repl.target docs update
ad4c0e3 [xiejiajun] Clear irrelevant code
a12d3a9 [xiejiajun] Support for manually specifying the Java version of Spark Interpreter Scala REPL and fix the CI failure due to low Scala version
ab2b191 [xiejiajun] Merge branch 'master' of https://github.com/apache/zeppelin into apache-master
5569788 [xiejiajun] Merge branch 'master' of https://github.com/apache/zeppelin into apache-master
0a9af6c [xiejiajun] Merge branch 'master' of https://github.com/apache/zeppelin into apache-master
be36b37 [xiejiajun] 合并Apache Master分支冲突解决
1335d55 [xiejiajun] Merge remote-tracking branch 'origin/master'
fc59f57 [JakeXie] Merge pull request #4 from apache/master
9cc70fe [xiejiajun] Merge remote-tracking branch 'origin/master'
6ef9b23 [xie-jia-jun] Merge pull request #3 from apache/master
45af87a [xiejiajun] added timeout for getting Thrift client to avoid situations where the interpreter may not be restarted when the interpreter process exits unexpectedly
f149c3b [xie-jia-jun] Merge pull request #1 from apache/master
5d4b645 [xie-jia-jun] Support OSSConfigStorage of Aliyun
dbb6639 [xie-jia-jun] Add Aliyun OSS SDK
bb47849 [xie-jia-jun] Support S3ConfigStorage of AWS
zjffdu pushed a commit that referenced this pull request Oct 18, 2020
…Spark Interpreter Scala REPL and fix the CI failure due to low Scala version

### What is this PR for?
- fix the [CI failure](https://travis-ci.org/github/apache/zeppelin/builds/709913046) due to [PR-3852](apache#3852)

### What type of PR is it?
[Bug Fix]

### Todos
* [ ] - Task

### What is the Jira issue?
* [ZEPPELIN-4962](https://issues.apache.org/jira/projects/ZEPPELIN/issues/ZEPPELIN-4962)

### How should this be tested?
* CI test

### Screenshots (if appropriate)

### Questions:
* Does the licenses files need update? NO
* Is there breaking changes for older versions? NO
* Does this needs documentation? Yes

Author: xiejiajun <[email protected]>
Author: xie-jia-jun <[email protected]>
Author: JakeXie <[email protected]>

Closes apache#3860 from xiejiajun/ZEPPELIN-4962 and squashes the following commits:

9128c9b [JakeXie] spark.repl.target docs update
ad4c0e3 [xiejiajun] Clear irrelevant code
a12d3a9 [xiejiajun] Support for manually specifying the Java version of Spark Interpreter Scala REPL and fix the CI failure due to low Scala version
ab2b191 [xiejiajun] Merge branch 'master' of https://github.com/apache/zeppelin into apache-master
5569788 [xiejiajun] Merge branch 'master' of https://github.com/apache/zeppelin into apache-master
0a9af6c [xiejiajun] Merge branch 'master' of https://github.com/apache/zeppelin into apache-master
be36b37 [xiejiajun] 合并Apache Master分支冲突解决
1335d55 [xiejiajun] Merge remote-tracking branch 'origin/master'
fc59f57 [JakeXie] Merge pull request #4 from apache/master
9cc70fe [xiejiajun] Merge remote-tracking branch 'origin/master'
6ef9b23 [xie-jia-jun] Merge pull request #3 from apache/master
45af87a [xiejiajun] added timeout for getting Thrift client to avoid situations where the interpreter may not be restarted when the interpreter process exits unexpectedly
f149c3b [xie-jia-jun] Merge pull request #1 from apache/master
5d4b645 [xie-jia-jun] Support OSSConfigStorage of Aliyun
dbb6639 [xie-jia-jun] Add Aliyun OSS SDK
bb47849 [xie-jia-jun] Support S3ConfigStorage of AWS

(cherry picked from commit 185ffd4)
Signed-off-by: Jeff Zhang <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants