Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cross village interaction #97

Merged
merged 5 commits into from
Jun 7, 2024
Merged

Cross village interaction #97

merged 5 commits into from
Jun 7, 2024

Conversation

ThomasThelen
Copy link
Collaborator

@ThomasThelen ThomasThelen commented Jun 6, 2024

Supports villages communicating with each other. This is achieved by wrapping villages into a village_manager class and passing it to models each time step. This allows for any village to access any other and make changes.

@ThomasThelen ThomasThelen changed the title [Draft] Cross village interaction Cross village interaction Jun 7, 2024
@ThomasThelen ThomasThelen requested a review from zizroc June 7, 2024 03:36
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine, though haven't tested it.

Copy link
Owner

@zizroc zizroc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't test the code as I'm doing this quickly. But I don't see any major errors, and worked on the same design on the IEP project model. Reminds me of an earlier phase of villager's development.

@zizroc zizroc merged commit b8c83b8 into main Jun 7, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants