Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add presigned jwt support #432

Merged
merged 1 commit into from
Feb 3, 2025

Conversation

Tolsto
Copy link
Contributor

@Tolsto Tolsto commented Jan 28, 2025

This pull request adds support for pre-signed JWTs as an alternative authentication method, fixing a limitation where private keys must be supplied directly. The current approach doesn't work with security hardware like Smartcards or Cloud HSMs where private keys can't be accessed directly.

Definition of Ready

  • I am happy with the code
  • Short description of the feature/issue is added in the pr description
  • PR is linked to the corresponding user story
  • Acceptance criteria are met
  • All open todos and follow ups are defined in a new ticket and justified
  • Deviations from the acceptance criteria and design are agreed with the PO and documented.
  • No debug or dead code
  • My code has no repetitions
  • Critical parts are tested automatically
  • Where possible E2E tests are implemented
  • Documentation/examples are up-to-date
  • All non-functional requirements are met
  • Functionality of the acceptance criteria is checked manually on the dev system.

@hifabienne hifabienne added the os-contribution This is a contribution from our open-source community label Jan 28, 2025
@Tolsto Tolsto force-pushed the add-presigned-jwt-support branch from c28a051 to cb18eb4 Compare January 28, 2025 12:01
@muhlemmer muhlemmer requested a review from livio-a January 29, 2025 10:32
@livio-a livio-a changed the title Add presigned jwt support feat: add presigned jwt support Feb 3, 2025
Copy link

codecov bot commented Feb 3, 2025

Codecov Report

Attention: Patch coverage is 0% with 31 lines in your changes missing coverage. Please review.

Project coverage is 0.05%. Comparing base (ecb8f77) to head (cb18eb4).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
pkg/client/zitadel/client.go 0.00% 16 Missing ⚠️
pkg/client/middleware/auth.go 0.00% 8 Missing ⚠️
pkg/client/auth.go 0.00% 7 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #432      +/-   ##
==========================================
- Coverage    0.05%    0.05%   -0.01%     
==========================================
  Files         130      130              
  Lines      107727   107757      +30     
==========================================
  Hits           57       57              
- Misses     107667   107697      +30     
  Partials        3        3              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@livio-a livio-a enabled auto-merge February 3, 2025 08:06
@livio-a
Copy link
Member

livio-a commented Feb 3, 2025

Hey @Tolsto thanks for the contribution!

If you want a small gift as a thank you, please reach out to [email protected]

@livio-a livio-a merged commit f02d530 into zitadel:main Feb 3, 2025
7 checks passed
Copy link
Contributor

github-actions bot commented Feb 3, 2025

🎉 This PR is included in version 3.4.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
os-contribution This is a contribution from our open-source community released
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants