Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove special chars from dirnames #378

Merged
merged 1 commit into from
Apr 11, 2018
Merged

Remove special chars from dirnames #378

merged 1 commit into from
Apr 11, 2018

Conversation

arkadiybutermanov
Copy link
Contributor

Using special characters in resource names may break git clone on Windows when API docs are stored in repo. This is mostly because some of these characters are considered as file separators.

The solution is to remove all characters listed here: https://msdn.microsoft.com/en-ca/library/windows/desktop/aa365247(v=vs.85).aspx#naming_conventions

Note: the same issue was fixed previously, but for filename only: #300

@arkadiybutermanov
Copy link
Contributor Author

@oestrich , could you please take a look at this tiny PR? Thanks!

@jakehow
Copy link
Member

jakehow commented Apr 11, 2018

lgtm

@oestrich oestrich merged commit 87cb1d4 into zipmark:master Apr 11, 2018
@oestrich
Copy link
Contributor

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants