Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Escape query_strings in DSL #297

Closed
wants to merge 1 commit into from
Closed

Escape query_strings in DSL #297

wants to merge 1 commit into from

Conversation

tarzan
Copy link
Contributor

@tarzan tarzan commented Jul 19, 2016

i.e. get "/api/v1/find?query=:my_query" should escape :my_query

i.e. `get "/api/v1/find?query=:my_query"` should escape `:my_query`
@tarzan
Copy link
Contributor Author

tarzan commented Jul 19, 2016

I had a hard time writing a spec for this 'cause I couldn't get all specs to pass locally. Would like me to try harder?

@jessedijkstra
Copy link

@oestrich Any chance you take a look at this?

@oestrich
Copy link
Contributor

oestrich commented Dec 8, 2016

Merged, locally. The failing test was the only test that was really needed since it specifically deal with that method.

@oestrich oestrich closed this Dec 8, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants