Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use tables to represent markdown parameters #265

Merged
merged 1 commit into from
Jun 23, 2016

Conversation

ianks
Copy link
Contributor

@ianks ianks commented Feb 19, 2016

The parameters in the previous markdown view were pretty ugly, and did not show the scope parameters. I made is so parameters are now rendered in a markdown table instead.

I ran into one hitch, I could not for the life of me make the cucumber spec pass. I manually ran:

be rspec app_spec.rb --require ./app.rb --format RspecApiDocumentation::ApiFormatter

Against a copy and pasted app_spec.rb and app.rb, and then diffed the outputs. They were exactly the same. I have no idea how to debug these cucumber tests, so I am probably doing it wrong. Any tips would be hugely appreciated 😄

Thanks for maintaining such a useful project!

EDIT: Looks like the specs passed on CI! Must be a local bug.

@ianks
Copy link
Contributor Author

ianks commented Feb 19, 2016

Here is what it looks like:

Imgur

@ianks
Copy link
Contributor Author

ianks commented Mar 18, 2016

@oestrich any chance we can get this merged?

@ianks
Copy link
Contributor Author

ianks commented Apr 19, 2016

Ping.

@ianks
Copy link
Contributor Author

ianks commented May 12, 2016

@zipmark Ping.

@joelind
Copy link

joelind commented Jun 8, 2016

👍

@oestrich
Copy link
Contributor

Sorry for just getting around to this. Looks good. Thanks!

@oestrich oestrich merged commit c41b803 into zipmark:master Jun 23, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants