fix: plumb partitionRange through one more spot

[tchow-zlai]

Summary

Checklist

• Added Unit Tests
• Covered by existing CI
• Integration tested
• Documentation update

Summary by CodeRabbit

• Refactor
  • Improved code clarity by using named parameters for partition range handling in partition availability checks. No changes to user-facing features or functionality.

[coderabbitai]

Walkthrough

This change updates how partition range information is passed to partition-related utility methods in the Spark codebase. Specifically, it modifies calls to lastAvailablePartition and firstAvailablePartition in the GroupBy object to include an explicit partitionRange parameter. Additionally, it updates calls to the partitions method in TableUtils.scala to use named parameters for clarity. No logic or control flow is altered, and public interfaces remain unchanged.

Changes

File(s)	Change Summary
spark/src/main/scala/ai/chronon/spark/GroupBy.scala	Updated calls to lastAvailablePartition and firstAvailablePartition to pass partitionRange = Option(queryRange) explicitly.
spark/src/main/scala/ai/chronon/spark/catalog/TableUtils.scala	Changed calls to partitions to use named parameter partitionRange, clarifying argument passing.

Possibly related PRs

• chore:remove unused method #533: Removes the partitionRange method from TableUtils.scala, which is directly related to the explicit partition range handling updated in this PR.

Suggested reviewers

• piyush-zlai
• nikhil-zlai
• varant-zlai

Poem

Partitions now with names so clear,
No more guessing which goes here!
Explicit range, a tidy call,
TableUtils stands proud and tall.
Code refines, confusion flees—
Spark’s logic flows with newfound ease!
✨

Warning

Review ran into problems

🔥 Problems

GitHub Actions and Pipeline Checks: Resource not accessible by integration - https://docs.github.com/rest/actions/workflow-runs#list-workflow-runs-for-a-repository.

Please grant the required permissions to the CodeRabbit GitHub App under the organization or repository settings.

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro (Legacy)

📥 Commits

Reviewing files that changed from the base of the PR and between 123f1bc and 108f089.

📒 Files selected for processing (2)

• spark/src/main/scala/ai/chronon/spark/GroupBy.scala (1 hunks)
• spark/src/main/scala/ai/chronon/spark/catalog/TableUtils.scala (2 hunks)

⏰ Context from checks skipped due to timeout of 90000ms (16)

• GitHub Check: streaming_tests
• GitHub Check: analyzer_tests
• GitHub Check: join_tests
• GitHub Check: streaming_tests
• GitHub Check: spark_tests
• GitHub Check: groupby_tests
• GitHub Check: groupby_tests
• GitHub Check: spark_tests
• GitHub Check: fetcher_tests
• GitHub Check: join_tests
• GitHub Check: batch_tests
• GitHub Check: fetcher_tests
• GitHub Check: analyzer_tests
• GitHub Check: scala_compile_fmt_fix
• GitHub Check: batch_tests
• GitHub Check: enforce_triggered_workflows

🔇 Additional comments (5)

spark/src/main/scala/ai/chronon/spark/catalog/TableUtils.scala (3)

233-234: Improved readability with named parameter.

Named parameter makes the code more maintainable.

---

239-240: Good use of named parameter.

Consistent with other similar changes.

---

423-423: LGTM! Consistent parameter naming.

Follows the pattern established in other methods.

spark/src/main/scala/ai/chronon/spark/GroupBy.scala (2)

594-596: Good changes for clarity.

Using named parameter helps trace the partitionRange flow through the codebase.

---

603-605: Consistent parameter naming.

Matches the pattern used in lastAvailablePartition.

---

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.