Adding step days of 1 to source job #578
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
WalkthroughThe Changes
Suggested reviewers
Poem
Warning Review ran into problems🔥 ProblemsGitHub Actions and Pipeline Checks: Resource not accessible by integration - https://docs.github.com/rest/actions/workflow-runs#list-workflow-runs-for-a-repository. Please grant the required permissions to the CodeRabbit GitHub App under the organization or repository settings. 📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
🧰 Additional context used🧬 Code Definitions (1)spark/src/main/scala/ai/chronon/spark/MergeJob.scala (4)
⏰ Context from checks skipped due to timeout of 90000ms (14)
🔇 Additional comments (5)
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
nikhil-zlai
reviewed
Apr 2, 2025
nikhil-zlai
approved these changes
Apr 2, 2025
nikhil-zlai
approved these changes
Apr 2, 2025
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (3)
spark/src/main/scala/ai/chronon/spark/MergeJob.scala (3)
57-58: Potential performance overhead scanning full range for schema.
66-79: Consider refining exception handling and logging the problematic day.
80-81: Check if DataFrame is empty before saving to avoid surprises.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro (Legacy)
📒 Files selected for processing (1)
spark/src/main/scala/ai/chronon/spark/MergeJob.scala(2 hunks)
🧰 Additional context used
🧬 Code Definitions (1)
spark/src/main/scala/ai/chronon/spark/MergeJob.scala (3)
api/src/main/scala/ai/chronon/api/DataRange.scala (4)
PartitionRange(38-128)PartitionRange(130-174)steps(82-87)shift(99-105)spark/src/main/scala/ai/chronon/spark/TableUtils.scala (1)
scanDf(593-613)spark/src/main/scala/ai/chronon/spark/BootstrapInfo.scala (3)
BootstrapInfo(51-74)BootstrapInfo(76-346)from(80-345)
⏰ Context from checks skipped due to timeout of 90000ms (14)
- GitHub Check: streaming_tests
- GitHub Check: streaming_tests
- GitHub Check: spark_tests
- GitHub Check: join_tests
- GitHub Check: analyzer_tests
- GitHub Check: spark_tests
- GitHub Check: groupby_tests
- GitHub Check: groupby_tests
- GitHub Check: fetcher_tests
- GitHub Check: fetcher_tests
- GitHub Check: analyzer_tests
- GitHub Check: scala_compile_fmt_fix
- GitHub Check: join_tests
- GitHub Check: enforce_triggered_workflows
🔇 Additional comments (5)
spark/src/main/scala/ai/chronon/spark/MergeJob.scala (5)
19-19: No issues with the new import.
62-65: Day-by-day iteration looks correct.
85-85: New parameter for daily range retrieval is consistent with the loop.
91-91: Watch for off-by-one errors when shifting day range by -1.
93-93: Leaving day range unshifted looks correct for non-snapshot accuracy.
nikhil-zlai
reviewed
Apr 2, 2025
Comment on lines
+67
to
+80
| val joinedDfTry = | ||
| try { | ||
| Success( | ||
| rightPartsData | ||
| .foldLeft(leftDf) { case (partialDf, (rightPart, rightDf)) => | ||
| joinWithLeft(partialDf, rightDf, rightPart) | ||
| } | ||
| // drop all processing metadata columns | ||
| .drop(Constants.MatchedHashes, Constants.TimePartitionColumn)) | ||
| } catch { | ||
| case e: Exception => | ||
| e.printStackTrace() | ||
| Failure(e) | ||
| } |
Contributor
There was a problem hiding this comment.
Suggested change
| val joinedDfTry = | |
| try { | |
| Success( | |
| rightPartsData | |
| .foldLeft(leftDf) { case (partialDf, (rightPart, rightDf)) => | |
| joinWithLeft(partialDf, rightDf, rightPart) | |
| } | |
| // drop all processing metadata columns | |
| .drop(Constants.MatchedHashes, Constants.TimePartitionColumn)) | |
| } catch { | |
| case e: Exception => | |
| e.printStackTrace() | |
| Failure(e) | |
| } | |
| val joinedDfTry = | |
| Try { | |
| rightPartsData | |
| .foldLeft(leftDf) { case (partialDf, (rightPart, rightDf)) => | |
| joinWithLeft(partialDf, rightDf, rightPart) | |
| } | |
| // drop all processing metadata columns | |
| .drop(Constants.MatchedHashes, Constants.TimePartitionColumn)) | |
| } |
4 tasks
kumar-zlai
pushed a commit
that referenced
this pull request
Apr 25, 2025
## Summary Adding step days of 1 to source job ## Checklist - [ ] Added Unit Tests - [ ] Covered by existing CI - [ ] Integration tested - [ ] Documentation update <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **New Features** - Data processing is now handled in daily segments, providing more precise and timely results. - **Bug Fixes** - Error messages have been refined to clearly indicate the specific day when a query yields no results, improving clarity during troubleshooting. <!-- end of auto-generated comment: release notes by coderabbit.ai --> --------- Co-authored-by: ezvz <[email protected]>
kumar-zlai
pushed a commit
that referenced
this pull request
Apr 29, 2025
## Summary Adding step days of 1 to source job ## Checklist - [ ] Added Unit Tests - [ ] Covered by existing CI - [ ] Integration tested - [ ] Documentation update <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **New Features** - Data processing is now handled in daily segments, providing more precise and timely results. - **Bug Fixes** - Error messages have been refined to clearly indicate the specific day when a query yields no results, improving clarity during troubleshooting. <!-- end of auto-generated comment: release notes by coderabbit.ai --> --------- Co-authored-by: ezvz <[email protected]>
chewy-zlai
pushed a commit
that referenced
this pull request
May 15, 2025
## Summary Adding step days of 1 to source job ## Checklist - [ ] Added Unit Tests - [ ] Covered by existing CI - [ ] Integration tested - [ ] Documentation update <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **New Features** - Data processing is now handled in daily segments, providing more precise and timely results. - **Bug Fixes** - Error messages have been refined to clearly indicate the specific day when a query yields no results, improving clarity during troubleshooting. <!-- end of auto-generated comment: release notes by coderabbit.ai --> --------- Co-authored-by: ezvz <[email protected]>
chewy-zlai
pushed a commit
that referenced
this pull request
May 15, 2025
## Summary Adding step days of 1 to source job ## Checklist - [ ] Added Unit Tests - [ ] Covered by existing CI - [ ] Integration tested - [ ] Documentation update <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **New Features** - Data processing is now handled in daily segments, providing more precise and timely results. - **Bug Fixes** - Error messages have been refined to clearly indicate the specific day when a query yields no results, improving clarity during troubleshooting. <!-- end of auto-generated comment: release notes by coderabbit.ai --> --------- Co-authored-by: ezvz <[email protected]>
chewy-zlai
pushed a commit
that referenced
this pull request
May 16, 2025
## Summary Adding step days of 1 to source job ## Cheour clientslist - [ ] Added Unit Tests - [ ] Covered by existing CI - [ ] Integration tested - [ ] Documentation update <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **New Features** - Data processing is now handled in daily segments, providing more precise and timely results. - **Bug Fixes** - Error messages have been refined to clearly indicate the specific day when a query yields no results, improving clarity during troubleshooting. <!-- end of auto-generated comment: release notes by coderabbit.ai --> --------- Co-authored-by: ezvz <[email protected]>
4 tasks
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adding step days of 1 to source job
Checklist
Summary by CodeRabbit