Revert Flink 1 task slot per TM and bump parallelism

[piyush-zlai]

Summary

We do see our existing Flink jobs (beacon listing actions) are just a touch overscaled. This seems to work to absorb event spikes but can be problematic if we're catching up when the job is down for some time. This PR bumps our parallelism up and also reverts the setting where we were going with 1 task slot / TM. We don't need that anymore as we've patched our catalyst code to handle generate exec nodes in the plan. So we can go back to running with task slots / TM. So we'll need the same resources as prior to this PR but get 2x the parallelism to allow us to catch up quicker.

Checklist

• Added Unit Tests
• Covered by existing CI
• Integration tested
• Documentation update

Summary by CodeRabbit

• Chores
  • Enhanced resource management and processing parallelism to improve performance under load.
  • Adjusted data scaling for more efficient and responsive streaming operations.

[coderabbitai]

Walkthrough

This pull request updates resource configuration settings for Flink job submissions. In the GCP integration, task manager memory settings and task slots in DataprocSubmitter.scala are increased, allowing for greater parallelism and improved memory allocation. In the Flink source, the scaleFactor in KafkaFlinkSource.scala is raised from 0.125 to 0.25, affecting implicit parallelism derivation.

Changes

File(s)	Change Summary
cloud_gcp/.../DataprocSubmitter.scala	Increased task manager process memory from "32G" to "64G", network memory adjusted (min: "512m" → "1G", max: "1G" → "2G"), off-heap memory increased from "512m" to "1G", task slots from 1 to 4.
flink/.../KafkaFlinkSource.scala	Raised scaleFactor from 0.125 to 0.25 to compute a higher implicit parallelism value based on the number of partitions.

Possibly related PRs

• Enable flamegraphs in Flink #527: Modifies resource allocation settings in DataprocSubmitter.scala with a new configuration property closely related to these changes.
• Flink updates - dial down to one slot per TM to get around CU issues #452: Adjusts task manager memory settings and task slots in a contrasting manner, indicating a direct configuration conflict.
• First cut at some prod friendly Flink settings for our Flink apps #226: Focuses on enhancing Flink job configuration for memory management and parallelism, directly aligning with these modifications.

Suggested reviewers

• kumar-zlai
• nikhil-zlai
• tchow-zlai

Poem

In code we tweak, in bytes we soar,
Memory grows, and slots are more.
Scale factors rise with silent cheer,
Parallel dreams now drawing near.
🎉 Happy changes, let logic steer!

Warning

Review ran into problems

🔥 Problems

GitHub Actions and Pipeline Checks: Resource not accessible by integration - https://docs.github.com/rest/actions/workflow-runs#list-workflow-runs-for-a-repository.

Please grant the required permissions to the CodeRabbit GitHub App under the organization or repository settings.

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro (Legacy)

📥 Commits

Reviewing files that changed from the base of the PR and between 53af9e8 and 79e4d04.

📒 Files selected for processing (2)

• cloud_gcp/src/main/scala/ai/chronon/integrations/cloud_gcp/DataprocSubmitter.scala (1 hunks)
• flink/src/main/scala/ai/chronon/flink/KafkaFlinkSource.scala (1 hunks)

⏰ Context from checks skipped due to timeout of 90000ms (3)

• GitHub Check: non_spark_tests
• GitHub Check: scala_compile_fmt_fix
• GitHub Check: non_spark_tests

🔇 Additional comments (4)

flink/src/main/scala/ai/chronon/flink/KafkaFlinkSource.scala (1)

32-32: Doubled scaleFactor increases implicit parallelism

Scaling from 0.125 to 0.25 doubles the calculated parallelism value.

cloud_gcp/src/main/scala/ai/chronon/integrations/cloud_gcp/DataprocSubmitter.scala (3)

124-127: Memory allocation increased to support higher parallelism

Task manager memory resources doubled to accommodate increased task slots.

---

128-131: Task slots per TM increased from 1 to 4

Quadrupling slots per task manager allows higher parallelism with same resource footprint. The added comment explains the rationale.

---

135-135: Off-heap memory doubled

Increases task off-heap memory from 512m to 1G to support more task slots.

---

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai plan to trigger planning for file edits and PR creation.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.