chore: bump bqms and iceberg version #530
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Thomas Chow <[email protected]>
Contributor
WalkthroughThis PR upgrades the Iceberg dependency versions across build configurations. In particular, it updates the JAR reference for the Iceberg BigQuery Catalog lib in the Bazel build, and revises the Iceberg Spark runtime artifacts (for both Scala 2.12 and 2.13) in the Maven configurations. Artifact hashes, new shaded packages, and HTTP client implementations are also added, ensuring that all related dependency entries reflect version 1.6.1. Changes
Possibly related PRs
Suggested reviewers
Poem
Warning Review ran into problems🔥 ProblemsGitHub Actions and Pipeline Checks: Resource not accessible by integration - https://docs.github.com/rest/actions/workflow-runs#list-workflow-runs-for-a-repository. Please grant the required permissions to the CodeRabbit GitHub App under the organization or repository settings. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
Co-authored-by: Thomas Chow <[email protected]>
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
tools/build_rules/dependencies/maven_repository.bzl (1)
88-88: Duplicate artifact entry.This is a duplicate of line 77 with the same artifact and version. Consider removing one instance.
- "org.apache.iceberg:iceberg-spark-runtime-3.5_2.12:1.6.1",
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro (Legacy)
⛔ Files ignored due to path filters (1)
cloud_gcp/iceberg-bigquery-catalog-1.6.1-1.0.1-beta.jaris excluded by!**/*.jar
📒 Files selected for processing (3)
cloud_gcp/BUILD.bazel(1 hunks)maven_install.json(8 hunks)tools/build_rules/dependencies/maven_repository.bzl(3 hunks)
🧰 Additional context used
🧠 Learnings (1)
cloud_gcp/BUILD.bazel (1)
Learnt from: tchow-zlai
PR: zipline-ai/chronon#393
File: cloud_gcp/BUILD.bazel:99-99
Timestamp: 2025-03-19T16:14:03.096Z
Learning: The jar file "iceberg-bigquery-catalog-1.5.2-1.0.1-beta.jar" in cloud_gcp/BUILD.bazel is a local dependency and should not be replaced with maven_artifact.
⏰ Context from checks skipped due to timeout of 90000ms (3)
- GitHub Check: non_spark_tests
- GitHub Check: non_spark_tests
- GitHub Check: enforce_triggered_workflows
🔇 Additional comments (11)
cloud_gcp/BUILD.bazel (1)
78-78: Version update confirmed.Iceberg BigQuery Catalog JAR upgraded from 1.5.2 to 1.6.1. This matches the overall Iceberg dependency update in this PR.
tools/build_rules/dependencies/maven_repository.bzl (2)
77-77: Iceberg version update.Spark runtime dependency version updated to 1.6.1.
100-100: Scala 2.13 version updated.Iceberg Spark runtime for Scala 2.13 updated to version 1.6.1.
maven_install.json (8)
3-4: Check artifact hashes.
Confirm new __INPUT_ARTIFACTS_HASH and __RESOLVED_ARTIFACTS_HASH are correct.
3466-3477: Iceberg Spark runtime update.
Hashes and version updated to 1.6.1—verify they match the official release.
20239-20244: New jctools entries.
Confirm new jctools shaded package entries are needed.
20767-20771: Nessie packages update.
Minor formatting/order changes; ensure they are intentional.
20912-20917: Repeat jctools shading.
Check duplicate jctools entries for consistency.
21440-21444: Nessie packages check.
Minor update; confirm consistency with overall configuration.
32717-32721: HTTP client mapping added.
New HttpClientFactory mappings added—verify necessity.
33534-33538: Duplicate HTTP mapping update.
Ensure consistency with the similar mapping above.
Co-authored-by: Thomas Chow <[email protected]>
david-zlai
approved these changes
Mar 24, 2025
kumar-zlai
pushed a commit
that referenced
this pull request
Apr 25, 2025
## Summary
Ran the canary integration tests!
```bash
<-----------------------------------------------------------------------------------
------------------------------------------------------------------------------------
DATAPROC LOGS
------------------------------------------------------------------------------------
------------------------------------------------------------------------------------>
++ cat tmp_metadata_upload.out
++ grep 'Dataproc submitter job id'
++ cut -d ' ' -f5
+ METADATA_UPLOAD_JOB_ID=0f0a7099-3f03-4487-b291-de26f3d56cdb
+ check_dataproc_job_state 0f0a7099-3f03-4487-b291-de26f3d56cdb
+ JOB_ID=0f0a7099-3f03-4487-b291-de26f3d56cdb
+ '[' -z 0f0a7099-3f03-4487-b291-de26f3d56cdb ']'
+ echo -e '\033[0;32m <<<<<<<<<<<<<<<<-----------------JOB STATUS----------------->>>>>>>>>>>>>>>>>\033[0m'
<<<<<<<<<<<<<<<<-----------------JOB STATUS----------------->>>>>>>>>>>>>>>>>
++ gcloud dataproc jobs describe 0f0a7099-3f03-4487-b291-de26f3d56cdb --region=us-central1 --format=flattened
++ grep status.state:
+ JOB_STATE='status.state: DONE'
+ echo status.state: DONE
status.state: DONE
+ '[' -z 'status.state: DONE' ']'
+ echo -e '\033[0;32m<<<<<.....................................FETCH.....................................>>>>>\033[0m'
<<<<<.....................................FETCH.....................................>>>>>
+ touch tmp_fetch.out
+ zipline run --repo=/Users/thomaschow/zipline-ai/chronon/api/py/test/canary --mode fetch --conf=production/group_bys/gcp/purchases.v1_dev -k '{"user_id":"5"}' --name gcp.purchases.v1_dev
+ tee tmp_fetch.out
+ grep -q purchase_price_average_14d
+ cat tmp_fetch.out
+ grep purchase_price_average_14d
"purchase_price_average_14d" : 72.5,
+ '[' 0 -ne 0 ']'
+ echo -e '\033[0;32m<<<<<.....................................SUCCEEDED!!!.....................................>>>>>\033[0m'
<<<<<.....................................SUCCEEDED!!!.....................................>>>>>
```
## Checklist
- [ ] Added Unit Tests
- [ ] Covered by existing CI
- [ ] Integration tested
- [ ] Documentation update
<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit
- **Chores**
- Upgraded several core dependency versions from 1.5.2 to 1.6.1.
- Updated artifact metadata, including revised checksums and additional
dependency entries, to enhance concurrency handling and HTTP client
support.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->
<!-- av pr metadata
This information is embedded by the av CLI when creating PRs to track
the status of stacks when using Aviator. Please do not delete or edit
this section of the PR.
```
{"parent":"main","parentHead":"","trunk":"main"}
```
-->
---------
Co-authored-by: Thomas Chow <[email protected]>
kumar-zlai
pushed a commit
that referenced
this pull request
Apr 29, 2025
## Summary
Ran the canary integration tests!
```bash
<-----------------------------------------------------------------------------------
------------------------------------------------------------------------------------
DATAPROC LOGS
------------------------------------------------------------------------------------
------------------------------------------------------------------------------------>
++ cat tmp_metadata_upload.out
++ grep 'Dataproc submitter job id'
++ cut -d ' ' -f5
+ METADATA_UPLOAD_JOB_ID=0f0a7099-3f03-4487-b291-de26f3d56cdb
+ check_dataproc_job_state 0f0a7099-3f03-4487-b291-de26f3d56cdb
+ JOB_ID=0f0a7099-3f03-4487-b291-de26f3d56cdb
+ '[' -z 0f0a7099-3f03-4487-b291-de26f3d56cdb ']'
+ echo -e '\033[0;32m <<<<<<<<<<<<<<<<-----------------JOB STATUS----------------->>>>>>>>>>>>>>>>>\033[0m'
<<<<<<<<<<<<<<<<-----------------JOB STATUS----------------->>>>>>>>>>>>>>>>>
++ gcloud dataproc jobs describe 0f0a7099-3f03-4487-b291-de26f3d56cdb --region=us-central1 --format=flattened
++ grep status.state:
+ JOB_STATE='status.state: DONE'
+ echo status.state: DONE
status.state: DONE
+ '[' -z 'status.state: DONE' ']'
+ echo -e '\033[0;32m<<<<<.....................................FETCH.....................................>>>>>\033[0m'
<<<<<.....................................FETCH.....................................>>>>>
+ touch tmp_fetch.out
+ zipline run --repo=/Users/thomaschow/zipline-ai/chronon/api/py/test/canary --mode fetch --conf=production/group_bys/gcp/purchases.v1_dev -k '{"user_id":"5"}' --name gcp.purchases.v1_dev
+ tee tmp_fetch.out
+ grep -q purchase_price_average_14d
+ cat tmp_fetch.out
+ grep purchase_price_average_14d
"purchase_price_average_14d" : 72.5,
+ '[' 0 -ne 0 ']'
+ echo -e '\033[0;32m<<<<<.....................................SUCCEEDED!!!.....................................>>>>>\033[0m'
<<<<<.....................................SUCCEEDED!!!.....................................>>>>>
```
## Checklist
- [ ] Added Unit Tests
- [ ] Covered by existing CI
- [ ] Integration tested
- [ ] Documentation update
<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit
- **Chores**
- Upgraded several core dependency versions from 1.5.2 to 1.6.1.
- Updated artifact metadata, including revised checksums and additional
dependency entries, to enhance concurrency handling and HTTP client
support.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->
<!-- av pr metadata
This information is embedded by the av CLI when creating PRs to track
the status of stacks when using Aviator. Please do not delete or edit
this section of the PR.
```
{"parent":"main","parentHead":"","trunk":"main"}
```
-->
---------
Co-authored-by: Thomas Chow <[email protected]>
chewy-zlai
pushed a commit
that referenced
this pull request
May 15, 2025
## Summary
Ran the canary integration tests!
```bash
<-----------------------------------------------------------------------------------
------------------------------------------------------------------------------------
DATAPROC LOGS
------------------------------------------------------------------------------------
------------------------------------------------------------------------------------>
++ cat tmp_metadata_upload.out
++ grep 'Dataproc submitter job id'
++ cut -d ' ' -f5
+ METADATA_UPLOAD_JOB_ID=0f0a7099-3f03-4487-b291-de26f3d56cdb
+ check_dataproc_job_state 0f0a7099-3f03-4487-b291-de26f3d56cdb
+ JOB_ID=0f0a7099-3f03-4487-b291-de26f3d56cdb
+ '[' -z 0f0a7099-3f03-4487-b291-de26f3d56cdb ']'
+ echo -e '\033[0;32m <<<<<<<<<<<<<<<<-----------------JOB STATUS----------------->>>>>>>>>>>>>>>>>\033[0m'
<<<<<<<<<<<<<<<<-----------------JOB STATUS----------------->>>>>>>>>>>>>>>>>
++ gcloud dataproc jobs describe 0f0a7099-3f03-4487-b291-de26f3d56cdb --region=us-central1 --format=flattened
++ grep status.state:
+ JOB_STATE='status.state: DONE'
+ echo status.state: DONE
status.state: DONE
+ '[' -z 'status.state: DONE' ']'
+ echo -e '\033[0;32m<<<<<.....................................FETCH.....................................>>>>>\033[0m'
<<<<<.....................................FETCH.....................................>>>>>
+ touch tmp_fetch.out
+ zipline run --repo=/Users/thomaschow/zipline-ai/chronon/api/py/test/canary --mode fetch --conf=production/group_bys/gcp/purchases.v1_dev -k '{"user_id":"5"}' --name gcp.purchases.v1_dev
+ tee tmp_fetch.out
+ grep -q purchase_price_average_14d
+ cat tmp_fetch.out
+ grep purchase_price_average_14d
"purchase_price_average_14d" : 72.5,
+ '[' 0 -ne 0 ']'
+ echo -e '\033[0;32m<<<<<.....................................SUCCEEDED!!!.....................................>>>>>\033[0m'
<<<<<.....................................SUCCEEDED!!!.....................................>>>>>
```
## Checklist
- [ ] Added Unit Tests
- [ ] Covered by existing CI
- [ ] Integration tested
- [ ] Documentation update
<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit
- **Chores**
- Upgraded several core dependency versions from 1.5.2 to 1.6.1.
- Updated artifact metadata, including revised checksums and additional
dependency entries, to enhance concurrency handling and HTTP client
support.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->
<!-- av pr metadata
This information is embedded by the av CLI when creating PRs to track
the status of stacks when using Aviator. Please do not delete or edit
this section of the PR.
```
{"parent":"main","parentHead":"","trunk":"main"}
```
-->
---------
Co-authored-by: Thomas Chow <[email protected]>
chewy-zlai
pushed a commit
that referenced
this pull request
May 15, 2025
## Summary
Ran the canary integration tests!
```bash
<-----------------------------------------------------------------------------------
------------------------------------------------------------------------------------
DATAPROC LOGS
------------------------------------------------------------------------------------
------------------------------------------------------------------------------------>
++ cat tmp_metadata_upload.out
++ grep 'Dataproc submitter job id'
++ cut -d ' ' -f5
+ METADATA_UPLOAD_JOB_ID=0f0a7099-3f03-4487-b291-de26f3d56cdb
+ check_dataproc_job_state 0f0a7099-3f03-4487-b291-de26f3d56cdb
+ JOB_ID=0f0a7099-3f03-4487-b291-de26f3d56cdb
+ '[' -z 0f0a7099-3f03-4487-b291-de26f3d56cdb ']'
+ echo -e '\033[0;32m <<<<<<<<<<<<<<<<-----------------JOB STATUS----------------->>>>>>>>>>>>>>>>>\033[0m'
<<<<<<<<<<<<<<<<-----------------JOB STATUS----------------->>>>>>>>>>>>>>>>>
++ gcloud dataproc jobs describe 0f0a7099-3f03-4487-b291-de26f3d56cdb --region=us-central1 --format=flattened
++ grep status.state:
+ JOB_STATE='status.state: DONE'
+ echo status.state: DONE
status.state: DONE
+ '[' -z 'status.state: DONE' ']'
+ echo -e '\033[0;32m<<<<<.....................................FETCH.....................................>>>>>\033[0m'
<<<<<.....................................FETCH.....................................>>>>>
+ touch tmp_fetch.out
+ zipline run --repo=/Users/thomaschow/zipline-ai/chronon/api/py/test/canary --mode fetch --conf=production/group_bys/gcp/purchases.v1_dev -k '{"user_id":"5"}' --name gcp.purchases.v1_dev
+ tee tmp_fetch.out
+ grep -q purchase_price_average_14d
+ cat tmp_fetch.out
+ grep purchase_price_average_14d
"purchase_price_average_14d" : 72.5,
+ '[' 0 -ne 0 ']'
+ echo -e '\033[0;32m<<<<<.....................................SUCCEEDED!!!.....................................>>>>>\033[0m'
<<<<<.....................................SUCCEEDED!!!.....................................>>>>>
```
## Checklist
- [ ] Added Unit Tests
- [ ] Covered by existing CI
- [ ] Integration tested
- [ ] Documentation update
<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit
- **Chores**
- Upgraded several core dependency versions from 1.5.2 to 1.6.1.
- Updated artifact metadata, including revised checksums and additional
dependency entries, to enhance concurrency handling and HTTP client
support.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->
<!-- av pr metadata
This information is embedded by the av CLI when creating PRs to track
the status of stacks when using Aviator. Please do not delete or edit
this section of the PR.
```
{"parent":"main","parentHead":"","trunk":"main"}
```
-->
---------
Co-authored-by: Thomas Chow <[email protected]>
chewy-zlai
pushed a commit
that referenced
this pull request
May 16, 2025
## Summary
Ran the canary integration tests!
```bash
<-----------------------------------------------------------------------------------
------------------------------------------------------------------------------------
DATAPROC LOGS
------------------------------------------------------------------------------------
------------------------------------------------------------------------------------>
++ cat tmp_metadata_upload.out
++ grep 'Dataproc submitter job id'
++ cut -d ' ' -f5
+ METADATA_UPLOAD_JOB_ID=0f0a7099-3f03-4487-b291-de26f3d56cdb
+ cheour clients_dataproc_job_state 0f0a7099-3f03-4487-b291-de26f3d56cdb
+ JOB_ID=0f0a7099-3f03-4487-b291-de26f3d56cdb
+ '[' -z 0f0a7099-3f03-4487-b291-de26f3d56cdb ']'
+ echo -e '\033[0;32m <<<<<<<<<<<<<<<<-----------------JOB STATUS----------------->>>>>>>>>>>>>>>>>\033[0m'
<<<<<<<<<<<<<<<<-----------------JOB STATUS----------------->>>>>>>>>>>>>>>>>
++ gcloud dataproc jobs describe 0f0a7099-3f03-4487-b291-de26f3d56cdb --region=us-central1 --format=flattened
++ grep status.state:
+ JOB_STATE='status.state: DONE'
+ echo status.state: DONE
status.state: DONE
+ '[' -z 'status.state: DONE' ']'
+ echo -e '\033[0;32m<<<<<.....................................FETCH.....................................>>>>>\033[0m'
<<<<<.....................................FETCH.....................................>>>>>
+ touch tmp_fetch.out
+ zipline run --repo=/Users/thomaschow/zipline-ai/chronon/api/py/test/canary --mode fetch --conf=production/group_bys/gcp/purchases.v1_dev -k '{"user_id":"5"}' --name gcp.purchases.v1_dev
+ tee tmp_fetch.out
+ grep -q purchase_price_average_14d
+ cat tmp_fetch.out
+ grep purchase_price_average_14d
"purchase_price_average_14d" : 72.5,
+ '[' 0 -ne 0 ']'
+ echo -e '\033[0;32m<<<<<.....................................SUCCEEDED!!!.....................................>>>>>\033[0m'
<<<<<.....................................SUCCEEDED!!!.....................................>>>>>
```
## Cheour clientslist
- [ ] Added Unit Tests
- [ ] Covered by existing CI
- [ ] Integration tested
- [ ] Documentation update
<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit
- **Chores**
- Upgraded several core dependency versions from 1.5.2 to 1.6.1.
- Updated artifact metadata, including revised cheour clientssums and additional
dependency entries, to enhance concurrency handling and HTTP client
support.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->
<!-- av pr metadata
This information is embedded by the av CLI when creating PRs to traour clients
the status of staour clientss when using Aviator. Please do not delete or edit
this section of the PR.
```
{"parent":"main","parentHead":"","trunk":"main"}
```
-->
---------
Co-authored-by: Thomas Chow <[email protected]>
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Ran the canary integration tests!
Checklist
Summary by CodeRabbit