Correct spelling of cananry and update aws release jar and wheel s3 paths #502
Conversation
WalkthroughThis update restructures the S3 bucket paths used by the artifact upload and quickstart scripts. The build script now employs a new directory for wheels and adjusts the path for JAR files, removing an outdated wheel upload step. Both AWS and GCP quickstart scripts correct a directory naming typo ("cananry-confs" → "canary-confs") and update S3 paths where applicable. No changes were made to public interfaces. Changes
Sequence Diagram(s)sequenceDiagram
participant BS as Build Script
participant S3 as AWS S3
BS->>S3: Upload JAR files to .../release/latest/jars/
BS->>S3: Upload wheel file via ELEMENT_WHEEL_PATH to .../release/latest/wheels/
sequenceDiagram
participant AWSQS as AWS Quickstart Script
participant Repo as GitHub Repository
participant S3 as AWS S3
AWSQS->>Repo: Clone canary-confs repository
AWSQS->>S3: Download wheel from .../release/latest/wheels/ path
Possibly related PRs
Suggested reviewers
Poem
Warning Review ran into problems🔥 ProblemsGitHub Actions and Pipeline Checks: Resource not accessible by integration - https://docs.github.com/rest/actions/workflow-runs#list-workflow-runs-for-a-repository. Please grant the required permissions to the CodeRabbit GitHub App under the organization or repository settings. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (6)
scripts/distribution/run_gcp_quickstart.sh (2)
8-8: Fix dir removal spelling.
Changed from "cananry-confs" to "canary-confs".
21-23: Correct clone & CD.
Repo URL and directory now use "canary-confs". Add|| exittocdfor safety.🧰 Tools
🪛 Shellcheck (0.10.0)
[warning] 23-23: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.
(SC2164)
scripts/distribution/run_aws_quickstart.sh (3)
20-20: Fix dir removal spelling.
Corrected to "canary-confs".
36-38: Correct clone & CD.
Now clones "canary-confs". Considercd canary-confs || exitto handle failures.🧰 Tools
🪛 Shellcheck (0.10.0)
[warning] 38-38: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.
(SC2164)
49-49: Update S3 wheel path.
New path:s3://zipline-artifacts-canary/release/latest/wheels/$WHEEL_FILE.scripts/distribution/build_and_upload_artifacts.sh (1)
214-219: Update S3 upload paths.
Using/release/latest/jars/for jars and/release/latest/wheels/for wheels.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro (Legacy)
📒 Files selected for processing (3)
scripts/distribution/build_and_upload_artifacts.sh(1 hunks)scripts/distribution/run_aws_quickstart.sh(3 hunks)scripts/distribution/run_gcp_quickstart.sh(2 hunks)
🧰 Additional context used
🪛 Shellcheck (0.10.0)
scripts/distribution/run_gcp_quickstart.sh
[warning] 23-23: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.
(SC2164)
scripts/distribution/run_aws_quickstart.sh
[warning] 38-38: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.
(SC2164)
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
scripts/distribution/run_aws_quickstart.sh (1)
38-38: Add cd error handling.
Use "cd canary-confs || exit" to handle potential failures.🧰 Tools
🪛 Shellcheck (0.10.0)
[warning] 38-38: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.
(SC2164)
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro (Legacy)
📒 Files selected for processing (1)
scripts/distribution/run_aws_quickstart.sh(3 hunks)
🧰 Additional context used
🪛 Shellcheck (0.10.0)
scripts/distribution/run_aws_quickstart.sh
[warning] 38-38: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.
(SC2164)
🔇 Additional comments (4)
scripts/distribution/run_aws_quickstart.sh (4)
20-20: Fix directory removal name.
Corrected "cananry-confs" to "canary-confs".
34-34: Set wheel filename.
Assigns the updated wheel file name.
37-37: Fix git clone URL.
Updated repo URL to use the correctly spelled "canary-confs".
49-49: Update S3 wheel path.
New S3 path reflects the updated release structure.
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
scripts/distribution/run_aws_quickstart.sh (1)
42-42: Shellcheck Suggestion: Add error handling tocd canary-confsto avoid directory change failure. For example:- cd canary-confs + cd canary-confs || exit 1🧰 Tools
🪛 Shellcheck (0.10.0)
[warning] 42-42: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.
(SC2164)
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro (Legacy)
📒 Files selected for processing (1)
scripts/distribution/run_aws_quickstart.sh(3 hunks)
🧰 Additional context used
🪛 Shellcheck (0.10.0)
scripts/distribution/run_aws_quickstart.sh
[warning] 42-42: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.
(SC2164)
🔇 Additional comments (5)
scripts/distribution/run_aws_quickstart.sh (5)
20-20: Typo Fixed: Corrected removal command from "cananry-confs" to "canary-confs".
38-38: Wheel Variable Updated: New wheel file version is defined.
40-40: Comment Clarification: The comment now correctly refers to canary configs.
41-41: Clone URL Corrected: Updated the repository URL from cananry to canary.
57-57: S3 Path Updated: The S3 command now correctly points to the new release wheels directory.
…aths (#502) …aths. ## Summary ## Checklist - [ ] Added Unit Tests - [ ] Covered by existing CI - [x] Integration tested - [ ] Documentation update <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **Chores** - Updated cloud artifact upload paths for improved organization and release consistency. - **Bug Fixes** - Corrected directory naming errors in quickstart scripts to ensure smooth deployment operations. - Fixed spelling errors in directory names for consistency across scripts. <!-- end of auto-generated comment: release notes by coderabbit.ai -->
…aths.
Summary
Checklist
Summary by CodeRabbit
Chores
Bug Fixes