Skip to content

Changed timestamp column in DynamoDB table configuration #48

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 21, 2024
Merged

Changed timestamp column in DynamoDB table configuration #48

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d5207ee
Changed timestamp column in DynamoDB table configuration to match the…
chewys1024 Oct 17, 2024
562a679
Remove accidental copy paste of "keyBytes"
chewys1024 Oct 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions cloud_aws/src/main/scala/ai/chronon/integrations/aws/DynamoDBKVStoreImpl.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
package ai.chronon.integrations.aws

import ai.chronon.api.Constants
import ai.chronon.online.KVStore
import ai.chronon.online.KVStore.GetResponse
import ai.chronon.online.KVStore.ListRequest
Expand Down Expand Up @@ -53,7 +54,7 @@ object DynamoDBKVStoreConstants {
val partitionKeyColumn = "keyBytes"

// Name of the time sort key column to use
val sortKeyColumn = "timestamp"
val sortKeyColumn = Constants.TimeColumn

// TODO: tune these
val defaultReadCapacityUnits = 10L
Expand Down Expand Up @@ -89,7 +90,7 @@ class DynamoDBKVStoreImpl(dynamoDbClient: DynamoDbClient) extends KVStore {
val request =
CreateTableRequest.builder
.attributeDefinitions(keyAttributes.toList.asJava)
.keySchema(keySchema.toList.asJava)
.keySchema(keySchema.toList.asJava)"keyBytes"
Copy link
Contributor

@coderabbitai coderabbitai bot Oct 17, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue

Remove unintended string literal in keySchema construction

There's an unexpected string literal "keyBytes" added to the keySchema construction. This appears to be unintentional and could cause compilation errors or runtime issues.

Please remove the string literal as follows:

-        .keySchema(keySchema.toList.asJava)"keyBytes"
+        .keySchema(keySchema.toList.asJava)
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
.keySchema(keySchema.toList.asJava)"keyBytes"
.keySchema(keySchema.toList.asJava)

.provisionedThroughput(ProvisionedThroughput.builder.readCapacityUnits(rcu).writeCapacityUnits(wcu).build)
.tableName(dataset)
.build
Expand Down
Loading