chore: reenable fetcher tests in bazel #478
Conversation
Co-authored-by: Thomas Chow <[email protected]>
WalkthroughThis change updates the dependency and resource management for the Spark test targets. In the Bazel build file, Changes
Suggested reviewers
Poem
Warning Review ran into problems🔥 ProblemsGitHub Actions and Pipeline Checks: Resource not accessible by integration - https://docs.github.com/rest/actions/workflow-runs#list-workflow-runs-for-a-repository. Please grant the required permissions to the CodeRabbit GitHub App under the organization or repository settings. 📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
⏰ Context from checks skipped due to timeout of 90000ms (13)
🔇 Additional comments (12)
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
Co-authored-by: Thomas Chow <[email protected]>
| singleFilePut.flatMap(putRequests => Await.result(putRequests, Duration.Inf)) | ||
|
|
||
| val response = inMemoryKvStore.get(GetRequest(joinPath.getBytes(), singleFileDataSet)) | ||
| val joinKeyName = "joins/team.example_join.v1" |
There was a problem hiding this comment.
Hey guys, so this is a change I'm not sure is exactly correct, but it does get the tests to pass. I had to change joins/team/example_join.v1 -> joins/team.example_join.v1 removing the second / since that didn't seem to match up with what was written to the kv store. Not sure if this behavior had changed at any point. cc @piyush-zlai @nikhil-zlai
There was a problem hiding this comment.
this is correct. join and groupby name in the metadata would have the team inside it.
ex:
quickstart.purchases.v1 where quickstart is the team
There was a problem hiding this comment.
wonder how this ever worked?
## Summary
- Use bazel runfiles to discover resources.
## Checklist
- [ ] Added Unit Tests
- [ ] Covered by existing CI
- [ ] Integration tested
- [ ] Documentation update
<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit
- **Chores**
- Updated dependency configurations to ensure consistent runtime support
and resource availability.
- **Tests**
- Enhanced resource handling for improved configuration loading.
- Re-enabled and optimized test scenarios for better coverage and
reliability.
- Improved clarity in test case execution with updated resource access
methods.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->
<!-- av pr metadata
This information is embedded by the av CLI when creating PRs to track
the status of stacks when using Aviator. Please do not delete or edit
this section of the PR.
```
{"parent":"main","parentHead":"","trunk":"main"}
```
-->
---------
Co-authored-by: Thomas Chow <[email protected]>
## Summary
- Use bazel runfiles to discover resources.
## Checklist
- [ ] Added Unit Tests
- [ ] Covered by existing CI
- [ ] Integration tested
- [ ] Documentation update
<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit
- **Chores**
- Updated dependency configurations to ensure consistent runtime support
and resource availability.
- **Tests**
- Enhanced resource handling for improved configuration loading.
- Re-enabled and optimized test scenarios for better coverage and
reliability.
- Improved clarity in test case execution with updated resource access
methods.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->
<!-- av pr metadata
This information is embedded by the av CLI when creating PRs to track
the status of stacks when using Aviator. Please do not delete or edit
this section of the PR.
```
{"parent":"main","parentHead":"","trunk":"main"}
```
-->
---------
Co-authored-by: Thomas Chow <[email protected]>
## Summary
- Use bazel runfiles to discover resources.
## Checklist
- [ ] Added Unit Tests
- [ ] Covered by existing CI
- [ ] Integration tested
- [ ] Documentation update
<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit
- **Chores**
- Updated dependency configurations to ensure consistent runtime support
and resource availability.
- **Tests**
- Enhanced resource handling for improved configuration loading.
- Re-enabled and optimized test scenarios for better coverage and
reliability.
- Improved clarity in test case execution with updated resource access
methods.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->
<!-- av pr metadata
This information is embedded by the av CLI when creating PRs to track
the status of stacks when using Aviator. Please do not delete or edit
this section of the PR.
```
{"parent":"main","parentHead":"","trunk":"main"}
```
-->
---------
Co-authored-by: Thomas Chow <[email protected]>
## Summary
- Use bazel runfiles to discover resources.
## Checklist
- [ ] Added Unit Tests
- [ ] Covered by existing CI
- [ ] Integration tested
- [ ] Documentation update
<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit
- **Chores**
- Updated dependency configurations to ensure consistent runtime support
and resource availability.
- **Tests**
- Enhanced resource handling for improved configuration loading.
- Re-enabled and optimized test scenarios for better coverage and
reliability.
- Improved clarity in test case execution with updated resource access
methods.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->
<!-- av pr metadata
This information is embedded by the av CLI when creating PRs to track
the status of stacks when using Aviator. Please do not delete or edit
this section of the PR.
```
{"parent":"main","parentHead":"","trunk":"main"}
```
-->
---------
Co-authored-by: Thomas Chow <[email protected]>
## Summary
- Use bazel runfiles to discover resources.
## Cheour clientslist
- [ ] Added Unit Tests
- [ ] Covered by existing CI
- [ ] Integration tested
- [ ] Documentation update
<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit
- **Chores**
- Updated dependency configurations to ensure consistent runtime support
and resource availability.
- **Tests**
- Enhanced resource handling for improved configuration loading.
- Re-enabled and optimized test scenarios for better coverage and
reliability.
- Improved clarity in test case execution with updated resource access
methods.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->
<!-- av pr metadata
This information is embedded by the av CLI when creating PRs to traour clients
the status of staour clientss when using Aviator. Please do not delete or edit
this section of the PR.
```
{"parent":"main","parentHead":"","trunk":"main"}
```
-->
---------
Co-authored-by: Thomas Chow <[email protected]>
Summary
Checklist
Summary by CodeRabbit