Added CI checks for artifacts pinning #417
Conversation
WalkthroughA new GitHub Actions workflow file has been added to test Bazel artifact pinning. The workflow triggers on pushes and pull requests to the Changes
Possibly related PRs
Suggested reviewers
Poem
Warning Review ran into problems🔥 ProblemsGitHub Actions and Pipeline Checks: Resource not accessible by integration - https://docs.github.com/rest/actions/workflow-runs#list-workflow-runs-for-a-repository. Please grant the required permissions to the CodeRabbit GitHub App under the organization or repository settings. ✨ Finishing Touches
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
## Summary Adds AWS build and push commands to the distribution script. ## Checklist - [ ] Added Unit Tests - [ ] Covered by existing CI - [ ] Integration tested - [ ] Documentation update <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **New Features** - Introduced an automated quickstart process for GCP deployments. - Enhanced the build and upload tool with flexible command-line options, supporting artifact creation for both AWS and GCP environments. - Added a new script for running the Zipline quickstart on GCP. - **Refactor** - Updated the AWS quickstart process to ensure consistent execution. <!-- end of auto-generated comment: release notes by coderabbit.ai -->
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
distribution/build_and_upload_artifacts.sh (1)
18-43: Arg parsing works.
Simple case structure; consider quoting$1in the unknown option message (e.g.,"Unknown option: '$1'").
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro (Legacy)
📒 Files selected for processing (2)
distribution/build_and_upload_artifacts.sh(3 hunks)tools/build_rules/dependencies/maven_repository.bzl(1 hunks)
✅ Files skipped from review due to trivial changes (1)
- tools/build_rules/dependencies/maven_repository.bzl
🔇 Additional comments (8)
distribution/build_and_upload_artifacts.sh (8)
3-10: Usage function added.
print_usagecleanly outlines available options.
12-16: No-argument check is clear.
Prints usage and exits when no args are given.
121-137: AWS build block is solid.
Conditionally builds AWS artifacts and verifies file existence.
138-156: GCP build block looks good.
Conditionally builds GCP artifacts with proper error checks.
161-161: GCP customer IDs defined.
Array initialization is concise and clear.
190-190: AWS customer IDs defined.
Array initialized correctly.
192-214:upload_to_awsfunction is clear.
Mirrors the GCP uploader; flows logically and concisely.
217-231: Conditional uploader invocation OK.
Chooses between batch and single-customer modes as intended.
|
This is redundant as our bazel config tests should also validate pinned artifacts other wise sync would fail |
Summary
Added new github workflow to our CI which checks if the currently pinned json files are up to date. This check will fail if there are any changes to the artifacts and they are re-pinned in which case we would need to re-pin and push the changes.
Checklist
Summary by CodeRabbit
New Features
Bug Fixes
Tests