Skip to content

Add maven artifact pinning support #412

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 21, 2025
Merged

Add maven artifact pinning support #412

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
71f92d9
Pinning artifacts logic working
kumar-zlai Feb 21, 2025
d8c887e
checking in json files as well
kumar-zlai Feb 21, 2025
d4cd708
Updated devnotes with instructions for re-pinning
kumar-zlai Feb 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion WORKSPACE
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,5 +111,10 @@ rules_proto_toolchains()

# To load all dependencies used across our modules
load("//tools/build_rules/dependencies:load_dependencies.bzl", "load_all_dependencies")

load_all_dependencies()

load("@maven//:defs.bzl", pinned_maven_repo_install = "pinned_maven_install")
pinned_maven_repo_install()

load("@spark//:defs.bzl", pinned_spark_repo_install = "pinned_maven_install")
Copy link
Contributor

@coderabbitai coderabbitai bot Feb 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue

Fix the alias name for spark repository install.

-load("@spark//:defs.bzl", pinned_spark_repo_install = "pinned_maven_install")
+load("@spark//:defs.bzl", pinned_spark_repo_install = "pinned_spark_install")
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
load("@spark//:defs.bzl", pinned_spark_repo_install = "pinned_maven_install")
load("@spark//:defs.bzl", pinned_spark_repo_install = "pinned_spark_install")

pinned_spark_repo_install()
18 changes: 18 additions & 0 deletions devnotes.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,6 +88,24 @@ This file is git-ignored.
build --google_credentials=/Users/{username}/.config/gcloud/application_default_credentials.json
```

### Pinning maven artifacts
We currently pin the versions for all our maven artifacts including all their transitive dependencies so
we don't have to resolve them during build time which can take up a very long time at times.

We currently have 2 different repositories
1. spark - contains all spark dependencies (pinned to spark_install.json file)
2. maven - contains all other maven dependencies (pinned to maven_install.json file)

Whenever we change any of the dependency artifacts in the above repositories we would need to re-pin and
update the json files using the below commands which need to be checked in

```shell
# For maven repo
REPIN=1 bazel run @maven//:pin
# For spark repo
REPIN=1 bazel run @spark//:pin
```

### Java not found error on Mac

In case you run into this error the fix is to manually download and install amazon corretto-17 from [here](https://docs.aws.amazon.com/corretto/latest/corretto-17-ug/downloads-list.html)
Expand Down
Loading