Revert "feat: bump spark to 3.5.4 (#392)"

[tchow-zlai]

Summary

• Even though I'm eager to get ahead here, let's not go too crazy and accidentally shoot ourselves in the foot. Let's stay pinned to what our clusters have (3.5.1) until those upgrade.

Checklist

• Added Unit Tests
• Covered by existing CI
• Integration tested
• Documentation update

Summary by CodeRabbit

• Chores
  • Updated core Spark libraries—impacting SQL, Hive, Streaming, and Avro features—to version 3.5.1 to ensure enhanced stability and improved integration across Spark-powered functionalities.

[coderabbitai]

Walkthrough

The pull request downgrades the Spark artifact versions in the spark_repository definition. Specifically, versions for spark-sql_2.12, spark-hive_2.12, spark-streaming_2.12, and spark-avro_2.12 are updated from 3.5.4 to 3.5.1. Other repository configurations remain unchanged.

Changes

File(s)	Change Summary
tools/build_rules/.../spark_repository.bzl	Downgraded versions for spark-sql_2.12, spark-hive_2.12, spark-streaming_2.12, and spark-avro_2.12 from 3.5.4 to 3.5.1

Possibly related PRs

• feat: bump spark to 3.5.4 #392: Related changes involving Spark version modifications within the same repository definition.

Suggested reviewers

• nikhil-zlai
• piyush-zlai
• chewy-zlai
• david-zlai
• kumar-zlai
• varant-zlai

Poem

In the code, a small downgrade in sight,
Spark versions shift, making everything light.
Old numbers fade, new numbers gleam,
A subtle change, a developer’s dream.
Code flows on like a sparkling stream ✨
Happy commits and a clean build theme!

Warning

Review ran into problems

🔥 Problems

GitHub Actions and Pipeline Checks: Resource not accessible by integration - https://docs.github.com/rest/actions/workflow-runs#list-workflow-runs-for-a-repository.

Please grant the required permissions to the CodeRabbit GitHub App under the organization or repository settings.

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro (Legacy)

📥 Commits

Reviewing files that changed from the base of the PR and between f9f8dba and 5f2647e.

📒 Files selected for processing (1)

• tools/build_rules/dependencies/spark_repository.bzl (1 hunks)

⏰ Context from checks skipped due to timeout of 90000ms (2)

• GitHub Check: bazel_config_tests
• GitHub Check: enforce_triggered_workflows

🔇 Additional comments (2)

tools/build_rules/dependencies/spark_repository.bzl (2)

11-14: Please provide context for the version downgrade.

Why was the upgrade to 3.5.4 reverted? This helps assess potential risks.

---

11-14:

❓ Verification inconclusive

Verify Spark 3.5.1 compatibility and stability.

---

🌐 Web query:

What is the latest stable version of Apache Spark 3.5.x? Are there any known issues with version 3.5.1?

💡 Result:

The latest stable version in the Apache Spark 3.5.x series is Spark 3.5.1, released as a maintenance update addressing security and correctness fixes[2][8]. This release includes dependency upgrades like aircompressor to v0.26 and resolves over 1,300 Jira tickets from the original 3.5.0 release[2][4].

Known issues with Spark 3.5.1 include:

• Memory configuration challenges:
  Some jobs require increased driver pod memory (minimum 1.2GB instead of default 1GB) to avoid OOMKilled errors in Kubernetes environments[5].

• RAZ S3 plugin failures:
  Cloudera Data Engineering clusters using RAZ authentication encounter initialization failures due to backward-incompatible library changes[5].

• Spot instance reliability:
  AWS spot instance shortages can cause job hangs in cloud deployments, requiring recreation of virtual clusters with on-demand instances[5].

• Session management:
  Killed Spark sessions might become unresponsive if interacted with post-termination[5].

• ELB subnet configuration:
  Public load balancer creation fails in environments without public subnets, requiring explicit subnet configuration[5].

These issues have documented workarounds like memory allocation adjustments and infrastructure configuration changes[2][5][8]. Users should review release notes and test upgrades in staging environments before production deployment[8].

Citations:

• 1: https://www.databricks.com/blog/introducing-apache-sparktm-35
• 2: https://spark.apache.org/releases/spark-release-3-5-1.html
• 3: https://community.cloudera.com/t5/Community-Articles/Spark-and-Java-versions-Supportability-Matrix/ta-p/383669
• 4: https://spark.apache.org/releases/spark-release-3-5-0.html
• 5: https://docs.cloudera.com/data-engineering/cloud/release-notes/topics/cde-general-known-issues.html
• 6: https://github.com/kubeflow/spark-operator
• 7: https://docs.delta.io/latest/releases.html
• 8: https://community.palantir.com/t/spark-3-5-1-upgrade/342
• 9: https://docs.couchbase.com/spark-connector/current/release-notes.html
• 10: https://spark.apache.org/downloads.html

---

Confirm Spark 3.5.1 Usage and Revert Context

• Verified: Spark 3.5.1 is the latest stable maintenance release in the 3.5.x series.
• Note: Known issues (e.g., memory configuration, session management) exist; ensure these are managed.
• Action: Please clarify the rationale for reverting from 3.5.4 to 3.5.1 and confirm consistency across the codebase.

---

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.