Skip to content

Ken/standardize scroll #350

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 10, 2025
Merged

Ken/standardize scroll #350

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
38c2631
remove ScrollArea and uses
ken-zlai Feb 7, 2025
3ffb370
add global scrollbar styles
ken-zlai Feb 7, 2025
a4c890d
Merge branch 'main' into ken/standardize-scroll
ken-zlai Feb 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 20 additions & 0 deletions frontend/src/app.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -119,16 +119,36 @@
--job-queued-bg: 0 0% 16%;
--job-queued-border: 0 0% 24%;
--job-queued-active-border: 0 0% 40%;

--scrollcolor: hsla(0, 0%, 13%, 1);
--scrollbackground: transparent;
scrollbar-color: var(--scrollcolor) var(--scrollbackground);
}
}

@layer base {
* {
@apply border-border antialiased;
scrollbar-width: thin;
}
body {
@apply bg-background text-foreground;
}

::-webkit-scrollbar {
border-radius: 1rem;
background: var(--scrollbackground);
}

::-webkit-scrollbar-thumb {
border-radius: 1rem;
background: var(--scrollcolor);
}

::-webkit-scrollbar-track {
border-radius: 1rem;
background: var(--scrollbackground);
}
}

@font-face {
Expand Down
10 changes: 0 additions & 10 deletions frontend/src/lib/components/ui/scroll-area/index.ts
View file
Open in desktop

This file was deleted.

27 changes: 0 additions & 27 deletions frontend/src/lib/components/ui/scroll-area/scroll-area-scrollbar.svelte
View file
Open in desktop

This file was deleted.

32 changes: 0 additions & 32 deletions frontend/src/lib/components/ui/scroll-area/scroll-area.svelte
View file
Open in desktop

This file was deleted.

5 changes: 2 additions & 3 deletions frontend/src/routes/+layout.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@
import NavigationSlider from '$lib/components/NavigationSlider.svelte';
import NavigationBar from '$lib/components/NavigationBar.svelte';
import BreadcrumbNav from '$lib/components/BreadcrumbNav.svelte';
import { ScrollArea } from '$lib/components/ui/scroll-area';
import { entityConfig } from '$lib/types/Entity/Entity';

let { children }: { children: Snippet } = $props();
Expand Down Expand Up @@ -33,11 +32,11 @@
<div
class="absolute top-0 left-0 w-full h-4 border-l border-t border-border rounded-tl-xl z-20"
></div>
<ScrollArea class="flex-1">
<div class="flex-1 overflow-y-auto">
<div class="px-8 py-5">
<BreadcrumbNav {breadcrumbs} class="mb-[38px]" />
{@render children()}
</div>
</ScrollArea>
</div>
</main>
</div>
5 changes: 2 additions & 3 deletions frontend/src/routes/joins/[slug]/observability/drift/+page.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,6 @@

import CollapsibleSection from '$lib/components/CollapsibleSection.svelte';
import type { ITileSummarySeries } from '$src/lib/types/codegen';
import { ScrollArea } from '$lib/components/ui/scroll-area';
import { Api } from '$lib/api/api';
import { Dialog, DialogContent, DialogHeader } from '$lib/components/ui/dialog';
import { formatDate } from '$lib/util/format';
Expand Down Expand Up @@ -219,7 +218,7 @@
/>
</DialogHeader>

<ScrollArea class="flex-grow px-7">
<div class="flex-grow px-7 overflow-y-auto">
{#if selectedSeriesPoint}
{@const [groupName, values] =
driftSeriesByGroupName.find(([_, values]) =>
Expand Down Expand Up @@ -367,7 +366,7 @@
{/snippet}
</CollapsibleSection>
{/if}
</ScrollArea>
</div>
</DialogContent>
</Dialog>

Expand Down