stability: use inter as fallback font #348
Conversation
WalkthroughThis pull request updates the project’s font configuration by adding two new @font-face rules in the CSS for the "Inter" font (regular and italic) with variable weights and swap display. It also adds documentation files including a README and SIL Open Font License text for the "Inter" font, and updates the Tailwind CSS configuration to include "Inter" in the sans-serif font stack. Changes
Poem
Warning Review ran into problems🔥 ProblemsGitHub Actions and Pipeline Checks: Resource not accessible by integration - https://docs.github.com/rest/actions/workflow-runs#list-workflow-runs-for-a-repository. Please grant the required permissions to the CodeRabbit GitHub App under the organization or repository settings. ✨ Finishing Touches
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (2)
frontend/src/app.css (1)
151-165: Consider using .woff2 format for better performance.While the current setup works, .woff2 format offers better compression and faster loading times.
@font-face { font-family: 'Inter'; - src: url('/fonts/Inter/Inter-VariableFont_opsz,wght.ttf') format('truetype-variations'); + src: url('/fonts/Inter/Inter-VariableFont_opsz,wght.woff2') format('woff2-variations'); font-weight: 100 900; font-style: normal; font-display: swap; } @font-face { font-family: 'Inter'; - src: url('/fonts/Inter/Inter-Italic-VariableFont_opsz,wght.ttf') format('truetype-variations'); + src: url('/fonts/Inter/Inter-Italic-VariableFont_opsz,wght.woff2') format('woff2-variations'); font-weight: 100 900; font-style: italic; font-display: swap; }frontend/static/fonts/Inter/README.txt (1)
15-15: Add comma for better readability.-Not all apps support variable fonts, and in those cases you can use the static font files for Inter: +Not all apps support variable fonts, and, in those cases, you can use the static font files for Inter:🧰 Tools
🪛 LanguageTool
[formatting] ~15-~15: Consider inserting a comma after an introductory phrase for better readability.
Context: ...ot all apps support variable fonts, and in those cases you can use the static font files for I...(IN_THAT_CASE_COMMA)
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro (Legacy)
⛔ Files ignored due to path filters (56)
frontend/static/fonts/Inter/Inter-Italic-VariableFont_opsz,wght.ttfis excluded by!**/*.ttffrontend/static/fonts/Inter/Inter-VariableFont_opsz,wght.ttfis excluded by!**/*.ttffrontend/static/fonts/Inter/static/Inter_18pt-Black.ttfis excluded by!**/*.ttffrontend/static/fonts/Inter/static/Inter_18pt-BlackItalic.ttfis excluded by!**/*.ttffrontend/static/fonts/Inter/static/Inter_18pt-Bold.ttfis excluded by!**/*.ttffrontend/static/fonts/Inter/static/Inter_18pt-BoldItalic.ttfis excluded by!**/*.ttffrontend/static/fonts/Inter/static/Inter_18pt-ExtraBold.ttfis excluded by!**/*.ttffrontend/static/fonts/Inter/static/Inter_18pt-ExtraBoldItalic.ttfis excluded by!**/*.ttffrontend/static/fonts/Inter/static/Inter_18pt-ExtraLight.ttfis excluded by!**/*.ttffrontend/static/fonts/Inter/static/Inter_18pt-ExtraLightItalic.ttfis excluded by!**/*.ttffrontend/static/fonts/Inter/static/Inter_18pt-Italic.ttfis excluded by!**/*.ttffrontend/static/fonts/Inter/static/Inter_18pt-Light.ttfis excluded by!**/*.ttffrontend/static/fonts/Inter/static/Inter_18pt-LightItalic.ttfis excluded by!**/*.ttffrontend/static/fonts/Inter/static/Inter_18pt-Medium.ttfis excluded by!**/*.ttffrontend/static/fonts/Inter/static/Inter_18pt-MediumItalic.ttfis excluded by!**/*.ttffrontend/static/fonts/Inter/static/Inter_18pt-Regular.ttfis excluded by!**/*.ttffrontend/static/fonts/Inter/static/Inter_18pt-SemiBold.ttfis excluded by!**/*.ttffrontend/static/fonts/Inter/static/Inter_18pt-SemiBoldItalic.ttfis excluded by!**/*.ttffrontend/static/fonts/Inter/static/Inter_18pt-Thin.ttfis excluded by!**/*.ttffrontend/static/fonts/Inter/static/Inter_18pt-ThinItalic.ttfis excluded by!**/*.ttffrontend/static/fonts/Inter/static/Inter_24pt-Black.ttfis excluded by!**/*.ttffrontend/static/fonts/Inter/static/Inter_24pt-BlackItalic.ttfis excluded by!**/*.ttffrontend/static/fonts/Inter/static/Inter_24pt-Bold.ttfis excluded by!**/*.ttffrontend/static/fonts/Inter/static/Inter_24pt-BoldItalic.ttfis excluded by!**/*.ttffrontend/static/fonts/Inter/static/Inter_24pt-ExtraBold.ttfis excluded by!**/*.ttffrontend/static/fonts/Inter/static/Inter_24pt-ExtraBoldItalic.ttfis excluded by!**/*.ttffrontend/static/fonts/Inter/static/Inter_24pt-ExtraLight.ttfis excluded by!**/*.ttffrontend/static/fonts/Inter/static/Inter_24pt-ExtraLightItalic.ttfis excluded by!**/*.ttffrontend/static/fonts/Inter/static/Inter_24pt-Italic.ttfis excluded by!**/*.ttffrontend/static/fonts/Inter/static/Inter_24pt-Light.ttfis excluded by!**/*.ttffrontend/static/fonts/Inter/static/Inter_24pt-LightItalic.ttfis excluded by!**/*.ttffrontend/static/fonts/Inter/static/Inter_24pt-Medium.ttfis excluded by!**/*.ttffrontend/static/fonts/Inter/static/Inter_24pt-MediumItalic.ttfis excluded by!**/*.ttffrontend/static/fonts/Inter/static/Inter_24pt-Regular.ttfis excluded by!**/*.ttffrontend/static/fonts/Inter/static/Inter_24pt-SemiBold.ttfis excluded by!**/*.ttffrontend/static/fonts/Inter/static/Inter_24pt-SemiBoldItalic.ttfis excluded by!**/*.ttffrontend/static/fonts/Inter/static/Inter_24pt-Thin.ttfis excluded by!**/*.ttffrontend/static/fonts/Inter/static/Inter_24pt-ThinItalic.ttfis excluded by!**/*.ttffrontend/static/fonts/Inter/static/Inter_28pt-Black.ttfis excluded by!**/*.ttffrontend/static/fonts/Inter/static/Inter_28pt-BlackItalic.ttfis excluded by!**/*.ttffrontend/static/fonts/Inter/static/Inter_28pt-Bold.ttfis excluded by!**/*.ttffrontend/static/fonts/Inter/static/Inter_28pt-BoldItalic.ttfis excluded by!**/*.ttffrontend/static/fonts/Inter/static/Inter_28pt-ExtraBold.ttfis excluded by!**/*.ttffrontend/static/fonts/Inter/static/Inter_28pt-ExtraBoldItalic.ttfis excluded by!**/*.ttffrontend/static/fonts/Inter/static/Inter_28pt-ExtraLight.ttfis excluded by!**/*.ttffrontend/static/fonts/Inter/static/Inter_28pt-ExtraLightItalic.ttfis excluded by!**/*.ttffrontend/static/fonts/Inter/static/Inter_28pt-Italic.ttfis excluded by!**/*.ttffrontend/static/fonts/Inter/static/Inter_28pt-Light.ttfis excluded by!**/*.ttffrontend/static/fonts/Inter/static/Inter_28pt-LightItalic.ttfis excluded by!**/*.ttffrontend/static/fonts/Inter/static/Inter_28pt-Medium.ttfis excluded by!**/*.ttffrontend/static/fonts/Inter/static/Inter_28pt-MediumItalic.ttfis excluded by!**/*.ttffrontend/static/fonts/Inter/static/Inter_28pt-Regular.ttfis excluded by!**/*.ttffrontend/static/fonts/Inter/static/Inter_28pt-SemiBold.ttfis excluded by!**/*.ttffrontend/static/fonts/Inter/static/Inter_28pt-SemiBoldItalic.ttfis excluded by!**/*.ttffrontend/static/fonts/Inter/static/Inter_28pt-Thin.ttfis excluded by!**/*.ttffrontend/static/fonts/Inter/static/Inter_28pt-ThinItalic.ttfis excluded by!**/*.ttf
📒 Files selected for processing (4)
frontend/src/app.css(1 hunks)frontend/static/fonts/Inter/OFL.txt(1 hunks)frontend/static/fonts/Inter/README.txt(1 hunks)frontend/tailwind.config.js(1 hunks)
🧰 Additional context used
🪛 LanguageTool
frontend/static/fonts/Inter/OFL.txt
[typographical] ~9-~9: If you want to indicate numerical ranges or time ranges, consider using an en dash.
Context: ...-----
SIL OPEN FONT LICENSE Version 1.1 - 26 February 2007
----------------------...
(DASH_RULE)
frontend/static/fonts/Inter/README.txt
[formatting] ~15-~15: Consider inserting a comma after an introductory phrase for better readability.
Context: ...ot all apps support variable fonts, and in those cases you can use the static font files for I...
(IN_THAT_CASE_COMMA)
⏰ Context from checks skipped due to timeout of 90000ms (1)
- GitHub Check: enforce_triggered_workflows
🔇 Additional comments (2)
frontend/tailwind.config.js (1)
112-112: LGTM!Font stack order is correct, with Inter as a fallback after Geist fonts.
frontend/static/fonts/Inter/OFL.txt (1)
1-93: LGTM!Standard SIL Open Font License, appropriate for font usage.
🧰 Tools
🪛 LanguageTool
[typographical] ~9-~9: If you want to indicate numerical ranges or time ranges, consider using an en dash.
Context: ...-----
SIL OPEN FONT LICENSE Version 1.1 - 26 February 2007
----------------------...(DASH_RULE)
sean-zlai
left a comment
sean-zlai
left a comment
There was a problem hiding this comment.
LGTM! So it will just fallback if Geist is not available, which since it's loading off our server, shouldn't really happen right?
|
yes, that is true |
Summary
Checklist
Summary by CodeRabbit
New Features
Documentation