Skip to content

Setup remote JVM debugging for app/hub #338

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 6, 2025
Merged

Setup remote JVM debugging for app/hub #338

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5deca0b
Setup remote JVM debugging for app/hub on port 5005
techniq Feb 6, 2025
2e21f25
Merge branch 'main' into sean/remote-jvm-debug
sean-zlai Feb 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions docker-init/compose.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,6 +67,7 @@ services:
- STATSD_HOST=statsd
ports:
- "9000:9000"
- "5005:5005"
healthcheck:
interval: 1s
retries: 5
Expand Down
8 changes: 7 additions & 1 deletion docker-init/start.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,4 +42,10 @@ start_time=$(date +%s)
# Add these java options as without them we hit the below error:
# throws java.lang.ClassFormatError accessible: module java.base does not "opens java.lang" to unnamed module @36328710
export JAVA_OPTS="--add-opens java.base/java.lang=ALL-UNNAMED --add-opens=java.base/java.util=ALL-UNNAMED"
exec java -jar hub-0.1.0-SNAPSHOT.jar run ai.chronon.hub.HubVerticle -Dserver.port=9000 -Dai.chronon.metrics.host=$STATSD_HOST -conf config.json
exec java \
-jar -agentlib:jdwp=transport=dt_socket,server=y,suspend=n,address=*:5005 hub-0.1.0-SNAPSHOT.jar \
run ai.chronon.hub.HubVerticle \
-Dserver.port=9000 \
-Dai.chronon.metrics.host=$STATSD_HOST \
-conf config.json
Comment on lines +45 to +50
Copy link
Contributor

@coderabbitai coderabbitai bot Feb 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue

JDWP order issue: Place -agentlib before -jar.

Consider this diff:

- exec java \
-   -jar -agentlib:jdwp=transport=dt_socket,server=y,suspend=n,address=*:5005  hub-0.1.0-SNAPSHOT.jar \
-   run ai.chronon.hub.HubVerticle \
-   -Dserver.port=9000 \
-   -Dai.chronon.metrics.host=$STATSD_HOST \
-   -conf config.json
+ exec java \
+   -agentlib:jdwp=transport=dt_socket,server=y,suspend=n,address=*:5005 \
+   -jar hub-0.1.0-SNAPSHOT.jar \
+   run ai.chronon.hub.HubVerticle \
+   -Dserver.port=9000 \
+   -Dai.chronon.metrics.host=$STATSD_HOST \
+   -conf config.json
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
exec java \
-jar -agentlib:jdwp=transport=dt_socket,server=y,suspend=n,address=*:5005 hub-0.1.0-SNAPSHOT.jar \
run ai.chronon.hub.HubVerticle \
-Dserver.port=9000 \
-Dai.chronon.metrics.host=$STATSD_HOST \
-conf config.json
exec java \
-agentlib:jdwp=transport=dt_socket,server=y,suspend=n,address=*:5005 \
-jar hub-0.1.0-SNAPSHOT.jar \
run ai.chronon.hub.HubVerticle \
-Dserver.port=9000 \
-Dai.chronon.metrics.host=$STATSD_HOST \
-conf config.json