Exclude rockdbjni from assembled Flink / cloud gcp jars

[piyush-zlai]

Summary

Hit some errors as our Spark deps pull in rocksdbjni 8.3.2 whereas we expect an older version in Flink (6.20.3-ververica-2.0). As we rely on user class first it seems like this newer version gets priority and when Flink is closing tiles we hit an error -

2025-02-05 21:14:53,614 INFO  org.apache.flink.runtime.executiongraph.ExecutionGraph       [] - Tiling for etsy.listing_canary.actions_v1 -> (Tiling Side Output Late Data for etsy.listing_canary.actions_v1, Avro conversion for etsy.listing_canary.actions_v1 -> async kvstore writes for etsy.listing_canary.actions_v1 -> Sink: Metrics Sink for etsy.listing_canary.actions_v1) (2/3) (a107444db4dad3eb79d9d02631d8696e_5627cd3c4e8c9c02fa4f114c4b3607f4_1_56) switched from RUNNING to FAILED on container_1738197659103_0039_01_000004 @ zipline-canary-cluster-w-1.us-central1-c.c.canary-443022.internal (dataPort=33465).
java.lang.NoSuchMethodError: 'void org.rocksdb.WriteBatch.remove(org.rocksdb.ColumnFamilyHandle, byte[])'
	at org.apache.flink.contrib.streaming.state.RocksDBWriteBatchWrapper.remove(RocksDBWriteBatchWrapper.java:105)

Yanked it out from the two jars and confirmed that the Flink job seems to be running fine + crossing over across hours (and hence tile closures).

Checklist

• Added Unit Tests
• Covered by existing CI
• Integration tested
• Documentation update

Summary by CodeRabbit

• Chores
  • Made internal adjustments to dependency management to improve compatibility between libraries and enhance overall application stability.

[coderabbitai]

Walkthrough

A new exclusion for the artifact "org.rocksdb:rocksdbjni" has been added to the excluded_artifacts list within the spark_repository function. This update is intended to prevent conflicts (e.g., with flink, cloud_gcp) and avoid a NoSuchMethodError for WriteBatch.remove. No other modifications were made to the file.

Changes

File	Change Summary
tools/.../spark_repository.bzl	Added exclusion for "org.rocksdb:rocksdbjni" with comments explaining conflict avoidance

Possibly related PRs

• Bazel changes to avoid runtime errors while running Spark and Flume jobs #274: Introduced a similar artifact exclusion (for commons-cli:commons-cli) in the spark_repository function to mitigate runtime errors.

Suggested reviewers

• nikhil-zlai
• tchow-zlai

Poem

In code we tweak and set things right,
A new exclusion brings clarity to light.
Rocksdb now stays out of the fray,
No errors to darken our build’s day.
Cheers to progress in a joyful byte!

Tip

🌐 Web search-backed reviews and chat

• We have enabled web search-based reviews and chat for all users. This feature allows CodeRabbit to access the latest documentation and information on the web.
• You can disable this feature by setting web_search: false in the knowledge_base settings.
• Please share any feedback in the Discord discussion.

Warning

Review ran into problems

🔥 Problems

GitHub Actions and Pipeline Checks: Resource not accessible by integration - https://docs.github.com/rest/actions/workflow-runs#list-workflow-runs-for-a-repository.

Please grant the required permissions to the CodeRabbit GitHub App under the organization or repository settings.

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro (Legacy)

📥 Commits

Reviewing files that changed from the base of the PR and between 9cf25f3 and 2555357.

📒 Files selected for processing (1)

• tools/build_rules/dependencies/spark_repository.bzl (1 hunks)

🔇 Additional comments (1)

tools/build_rules/dependencies/spark_repository.bzl (1)

32-35: LGTM! Exclusion resolves the version conflict.

The exclusion aligns with the PR objective to resolve the rocksdbjni version conflict between Spark and Flink.

Let's verify the build configuration:

✅ Verification successful

🏁 Script executed:

#!/bin/bash
# Description: Check for other rocksdbjni dependencies that might conflict
rg -i "rocksdbjni" --type bazel

Length of output: 117

---

LGTM! The exclusion of rocksdbjni is correctly applied and no additional conflicting dependencies are found.

• Only reference exists in tools/build_rules/dependencies/spark_repository.bzl.

---

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.