explode support in catalyst util test #280

nikhil-zlai · 2025-01-27T23:45:25Z

Summary

Changed return type to seq (backed by ArrayBuffer under the hood). Added unit tests.

Checklist

Added Unit Tests
Covered by existing CI
Integration tested
Documentation update

Summary by CodeRabbit

Refactor
- Updated SQL utility methods to return sequences of results instead of optional single results.
- Modified result handling in SQL-related utility classes to support multiple result rows.
- Enhanced logic to handle cases with no valid inputs in data processing methods.
Tests
- Updated test cases to accommodate new result handling approach.
- Added new test for handling "explode" invocations in SQL select clauses.
- Refined handling of null values and special floating-point values in tests.
Bug Fixes
- Improved error handling and result processing in SQL transformation methods.

coderabbitai · 2025-01-27T23:45:32Z

Walkthrough

The pull request introduces significant changes to the CatalystUtil and related classes in the online module. The primary modification involves transforming method return types from optional single results to sequences of results. This change affects how SQL transformations are handled, enabling more flexible result processing across multiple methods in the CatalystUtil, PooledCatalystUtil, and associated test classes.

Changes

File	Change Summary
`online/src/main/scala/ai/chronon/online/CatalystUtil.scala`	- Updated `performSql` methods to return `Seq` instead of `Option` - Modified internal transformation logic to handle multiple results
`online/src/main/scala/ai/chronon/online/OnlineDerivationUtil.scala`	- Updated SQL result handling to use `.headOption` for safer result extraction
`online/src/test/scala/ai/chronon/online/test/CatalystUtilHiveUDFTest.scala`	- Adjusted result handling in tests to reflect new `Seq` structure
`online/src/test/scala/ai/chronon/online/test/CatalystUtilTest.scala`	- Updated `performSql` calls to use `.headOption` - Added new test for "explode" invocations
`online/src/test/scala/ai/chronon/online/test/ThriftDecodingTest.scala`	- Modified result handling to avoid nulls and serialize only the first element
`online/src/main/scala/ai/chronon/online/stats/PivotUtils.scala`	- Introduced `sawValidInput` to manage valid input checks in `collectDoubles`
`online/src/test/scala/ai/chronon/online/test/stats/PivotUtilsTest.scala`	- Updated tests to handle nulls and special floating-point values consistently

Possibly related PRs

Summary upload #50: Changes in SummaryUploader related to data uploads and SQL transformations.
metrics fixes #78: Modifications to metricPopulatorFunc with error handling for null values.
Add support to register UDFs in Flink #142: Modifications to CatalystUtil class instantiation.

Suggested Reviewers

piyush-zlai
ken-zlai

Poem

🔍 Catalyst transforms, results unfurl
From Option's cage, a Sequence swirls
SQL dances with newfound might
Rows cascade in data's delight
Code evolves, no longer shy! 🚀

Warning

Review ran into problems

🔥 Problems

GitHub Actions: Resource not accessible by integration - https://docs.github.com/rest/actions/workflow-runs#list-workflow-runs-for-a-repository.

Please grant the required permissions to the CodeRabbit GitHub App under the organization or repository settings.

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro (Legacy)

📥 Commits

Reviewing files that changed from the base of the PR and between f131c09 and 130cc8c.

📒 Files selected for processing (1)

online/src/test/scala/ai/chronon/online/test/CatalystUtilHiveUDFTest.scala (2 hunks)

🚧 Files skipped from review as they are similar to previous changes (1)

online/src/test/scala/ai/chronon/online/test/CatalystUtilHiveUDFTest.scala

⏰ Context from checks skipped due to timeout of 90000ms (2)

GitHub Check: no_spark_scala_tests
GitHub Check: scala_compile_fmt_fix

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

nikhil-zlai · 2025-01-28T03:18:24Z

online/src/main/scala/ai/chronon/online/stats/PivotUtils.scala

      .setTimestamps(timestamps.iterator.map(JLong.valueOf) |> collect)
  }

  private def collectDoubles(vals: Iterator[JDouble]): JList[JDouble] = {


another pr broke this - not sure how that went in. so fixing to get the ci passing on this one.

coderabbitai

Actionable comments posted: 0

🧹 Nitpick comments (1)

online/src/main/scala/ai/chronon/online/stats/PivotUtils.scala (1)

117-132: Optimize memory usage by filtering invalid inputs.

Currently collecting all values even when invalid. Consider filtering out invalid values to reduce memory usage.

 private def collectDoubles(vals: Iterator[JDouble]): JList[JDouble] = {
   val result = new JArrayList[JDouble]()
   var sawValidInput = false
 
   while (vals.hasNext) {
     val next = vals.next()
-    val thisIsValid = next != Constants.magicNullDouble && next != null
+    if (next != Constants.magicNullDouble && next != null) {
+      result.add(next)
      sawValidInput = sawValidInput || thisIsValid
-    }
-    result.add(next)
+    }
   }
 
   if (!sawValidInput) null else result
 }

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro (Legacy)

📥 Commits

Reviewing files that changed from the base of the PR and between 7cd3a44 and f131c09.

📒 Files selected for processing (2)

online/src/main/scala/ai/chronon/online/stats/PivotUtils.scala (1 hunks)
online/src/test/scala/ai/chronon/online/test/stats/PivotUtilsTest.scala (4 hunks)

⏰ Context from checks skipped due to timeout of 90000ms (2)

GitHub Check: no_spark_scala_tests
GitHub Check: scala_compile_fmt_fix

🔇 Additional comments (5)

online/src/test/scala/ai/chronon/online/test/stats/PivotUtilsTest.scala (4)

255-258: LGTM: Consistent null handling with magic constant

260-260: LGTM: Clear test for unset histogram drift

294-295: LGTM: Consistent null handling for unset series

313-313: LGTM: NaN consistently replaced with magic constant

online/src/main/scala/ai/chronon/online/stats/PivotUtils.scala (1)

Line range hint 156-176: LGTM! Consistent null handling across drift calculations.

The changes align with the PR objective to modify return types and provide consistent null handling.

## Summary Changed return type to seq (backed by ArrayBuffer under the hood). Added unit tests. ## Checklist - [x] Added Unit Tests - [x] Covered by existing CI - [ ] Integration tested - [ ] Documentation update  ## Summary by CodeRabbit - **Refactor** - Updated SQL utility methods to return sequences of results instead of optional single results. - Modified result handling in SQL-related utility classes to support multiple result rows. - Enhanced logic to handle cases with no valid inputs in data processing methods. - **Tests** - Updated test cases to accommodate new result handling approach. - Added new test for handling "explode" invocations in SQL select clauses. - Refined handling of null values and special floating-point values in tests. - **Bug Fixes** - Improved error handling and result processing in SQL transformation methods.

## Summary Changed return type to seq (baour clientsed by ArrayBuffer under the hood). Added unit tests. ## Cheour clientslist - [x] Added Unit Tests - [x] Covered by existing CI - [ ] Integration tested - [ ] Documentation update  ## Summary by CodeRabbit - **Refactor** - Updated SQL utility methods to return sequences of results instead of optional single results. - Modified result handling in SQL-related utility classes to support multiple result rows. - Enhanced logic to handle cases with no valid inputs in data processing methods. - **Tests** - Updated test cases to accommodate new result handling approach. - Added new test for handling "explode" invocations in SQL select clauses. - Refined handling of null values and special floating-point values in tests. - **Bug Fixes** - Improved error handling and result processing in SQL transformation methods.

nikhil-zlai requested a review from piyush-zlai January 27, 2025 23:45

piyush-zlai approved these changes Jan 28, 2025

View reviewed changes

explode support in catalyst util test

7cd3a44

nikhil-zlai force-pushed the catalyst_explode branch from b719fc4 to 7cd3a44 Compare January 28, 2025 02:53

pivot test fix

f131c09

nikhil-zlai commented Jan 28, 2025

View reviewed changes

coderabbitai bot reviewed Jan 28, 2025

View reviewed changes

varant-zlai approved these changes Jan 28, 2025

View reviewed changes

test fix

130cc8c

nikhil-zlai merged commit 01a2f70 into main Jan 28, 2025
5 checks passed

nikhil-zlai deleted the catalyst_explode branch January 28, 2025 15:39

This was referenced Jan 31, 2025

Switch out old APIs #259

Merged

Flink updates to use TileKey on tiling flow writes #307

Merged

coderabbitai bot mentioned this pull request Feb 14, 2025

Update Catalyst util to bump up whole stage codegen limit for Beacon top #380

Merged

4 tasks

coderabbitai bot mentioned this pull request Feb 25, 2025

modify functions to allow frontend to pass percentiles #434

Merged

4 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

explode support in catalyst util test #280

explode support in catalyst util test #280

Uh oh!

nikhil-zlai commented Jan 27, 2025 •

edited by coderabbitai bot

Loading

Uh oh!

coderabbitai bot commented Jan 27, 2025 •

edited

Loading

Review ran into problems

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

Uh oh!

nikhil-zlai Jan 28, 2025

Uh oh!

coderabbitai bot left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

explode support in catalyst util test #280

explode support in catalyst util test #280

Uh oh!

Conversation

nikhil-zlai commented Jan 27, 2025 • edited by coderabbitai bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Checklist

Summary by CodeRabbit

Uh oh!

coderabbitai bot commented Jan 27, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Possibly related PRs

Suggested Reviewers

Poem

Review ran into problems

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

Uh oh!

nikhil-zlai Jan 28, 2025

Choose a reason for hiding this comment

Uh oh!

coderabbitai bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

nikhil-zlai commented Jan 27, 2025 •

edited by coderabbitai bot

Loading

coderabbitai bot commented Jan 27, 2025 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)