-
Notifications
You must be signed in to change notification settings - Fork 9
cli v2 #277
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
cli v2 #277
Changes from all commits
Commits
Show all changes
40 commits
Select commit
Hold shift + click to select a range
ba7f7fe
cli v2
nikhil-zlai 84eb325
Switch out old APIs (#259)
ken-zlai 85a1302
changes
nikhil-zlai fb79a9f
more changes
nikhil-zlai 30735ee
fixes
nikhil-zlai 038c12e
changes so far
nikhil-zlai e81d1b7
cli v2
nikhil-zlai 42165bf
save
nikhil-zlai 48d8438
thrift + bazel + ci docker changes
nikhil-zlai 9444a2f
bazelification of non-spark tests in ci
nikhil-zlai 583544f
docker back to aarch64
nikhil-zlai 1d2e443
docker back to amd64
nikhil-zlai 3b40973
spark tests in ci
nikhil-zlai d7556d3
chmod +x bazel
nikhil-zlai eeedd5c
cleanup
nikhil-zlai a761a46
amd64 jdk
nikhil-zlai ba4414e
fat build and push runner
nikhil-zlai 605c6db
disable resource loader tests, will fix after cut-over
nikhil-zlai d82cde0
scalafmt
nikhil-zlai fd712e4
install python venv in docker
nikhil-zlai 770013d
bazelrc to use remote cache
nikhil-zlai a13d6ad
trailing whitespaces
nikhil-zlai a69354b
python test fix
nikhil-zlai f06c541
ignore linting in cli dir
nikhil-zlai 0b46958
lint fixes
nikhil-zlai c4976fe
validator back
nikhil-zlai 03c77b0
lint fixes
nikhil-zlai d9d9905
validator in the right place
nikhil-zlai 2f7b3b1
validator in the right place
nikhil-zlai f8d10aa
revert validator
nikhil-zlai e92a9fc
conf validator renaming
nikhil-zlai ef6243b
pytest fixes
nikhil-zlai e671abc
Added test option to output error logs for failed tests
b23292e
test_passing
nikhil-zlai 9b01574
git install
nikhil-zlai 3e0c5f0
docker on ubuntu-latest
nikhil-zlai 82704f3
Specify git user name and email for the python tests
kumar-zlai b3a30f0
To add sbt clean step before doing format checks
kumar-zlai 845949f
Add UTF-8 encoding setting for thrift gen needed for CI
kumar-zlai 3858d3d
Remove locale gen
kumar-zlai File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,2 +1,5 @@ | ||
| build --java_language_version=11 | ||
| build --java_runtime_version=11 | ||
| build --java_runtime_version=11 | ||
| build --remote_cache=https://storage.googleapis.com/zipline-bazel-cache | ||
| build --google_default_credentials | ||
| test --test_output=errors |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -33,20 +33,28 @@ jobs: | |
| steps: | ||
| - uses: actions/checkout@v4 | ||
|
|
||
| - name: Set up Python virtual environment | ||
| - name: Configure Git | ||
| run: | | ||
| git config --global user.email "[email protected]" | ||
| git config --global user.name "GitHub Actions" | ||
|
|
||
| - name: Set up Python virtual environment | ||
| shell: bash | ||
| run: | | ||
| python3 -m venv chronon_py_env | ||
| source chronon_py_env/bin/activate | ||
|
|
||
| - name: Run Chronon Python lint | ||
| shell: bash | ||
| run: | | ||
| source chronon_py_env/bin/activate | ||
| cd api/py/ai/chronon | ||
| pip install importlib-metadata==4.11.4 | ||
| pip install flake8 | ||
| flake8 --extend-ignore=W605,Q000,F631 | ||
| flake8 --extend-ignore=W605,Q000,F631 --exclude=cli | ||
|
|
||
| - name: Run Chronon Python tests | ||
| shell: bash | ||
| run: | | ||
| source chronon_py_env/bin/activate | ||
| thrift --gen py -out api/py/ api/thrift/common.thrift | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🛠️ Refactor suggestion
Pin Ubuntu version for reproducibility.
📝 Committable suggestion