fix: use the correct dataframereader to do the read

[tchow-zlai]

Summary

• Should be using the same reader as every other case.

Checklist

• Added Unit Tests
• Covered by existing CI
• Integration tested
• Documentation update

Summary by CodeRabbit

• Improvements
  • Enhanced data loading consistency for Hive, Delta, and Iceberg table formats
  • Ensured that DataFrameReader options are consistently applied when loading tables

[coderabbitai]

Walkthrough

The pull request modifies the DataPointerAwareDataFrameReader class in the Spark Extensions, specifically updating the load method's handling of table loading for Hive, Delta, and Iceberg formats. The change ensures that DataFrameReader options are consistently applied when loading tables, using optionDfr.table(tableOrPath) instead of the previous direct dfr.table(tableOrPath) approach.

Changes

File	Change Summary
spark/src/main/scala/ai/chronon/spark/Extensions.scala	Updated table loading method to consistently apply DataFrameReader options for Hive, Delta, and Iceberg formats

Possibly related PRs

• feat: CatalogAwareDataPointer and refactoring existing DataPointer #157: Changes in DataPointer and CatalogAwareDataPointer related to data loading and format management

Poem

🔍 Spark's tables now load with grace,
Options dancing in each embrace
Hive, Delta, Iceberg take flight
With consistent reader's might!
Code flows smooth as morning light 🌟

Warning

Review ran into problems

🔥 Problems

GitHub Actions: Resource not accessible by integration - https://docs.github.com/rest/actions/workflow-runs#list-workflow-runs-for-a-repository.

Please grant the required permissions to the CodeRabbit GitHub App under the organization or repository settings.

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro (Legacy)

📥 Commits

Reviewing files that changed from the base of the PR and between 9fb0e60 and 2a749ba.

📒 Files selected for processing (1)

• spark/src/main/scala/ai/chronon/spark/Extensions.scala (1 hunks)

⏰ Context from checks skipped due to timeout of 90000ms (6)

• GitHub Check: table_utils_delta_format_spark_tests
• GitHub Check: other_spark_tests
• GitHub Check: join_spark_tests
• GitHub Check: fetcher_spark_tests
• GitHub Check: mutation_spark_tests
• GitHub Check: scala_compile_fmt_fix

🔇 Additional comments (1)

spark/src/main/scala/ai/chronon/spark/Extensions.scala (1)

370-370: LGTM: Consistent options handling for table formats.

The change ensures DataFrameReader options are properly applied when loading Hive, Delta, and Iceberg tables.

Let's verify the impact:

✅ Verification successful

Verified: Change is properly isolated to DataPointerAwareDataFrameReader

The switch to optionDfr.table is contained within the DataPointerAwareDataFrameReader class and doesn't require similar updates elsewhere in the codebase.

🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Search for other table loading patterns that might need similar fixes
rg -A 2 "dfr\.table\(" --type scala

Length of output: 37

---

Script:

#!/bin/bash
# Search for table loading patterns with broader context
rg -t scala -A 3 '\.table\(' 

# Also search for DataFrameReader usage patterns
rg -t scala -A 3 'DataFrameReader'

Length of output: 13465

---

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.