Skip to content

Migrate ECharts usage to LayerChart #251

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 45 commits into from
Feb 6, 2025
Merged

Migrate ECharts usage to LayerChart #251

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
45 commits
Select commit Hold shift + click to select a range
983f7fc
Setup LayerChart
techniq Jan 20, 2025
e71f7f6
feat: Add FeaturesLineChart, PercentileLineChart, and common chart pr…
techniq Jan 20, 2025
0889632
Replace distributions ECharts with LayerChart
techniq Jan 20, 2025
cd3f490
Replace drifts ECharts usage with LayerChart
techniq Jan 20, 2025
b98202d
Remove d3-array and d3-scale packages (and just use the main `d3` pac…
techniq Jan 20, 2025
5b39b3c
fix: Add placeholder space for last feature chart tooltip
techniq Jan 21, 2025
06557e0
Experiment with using canvas rendering (needs hitcanvas for click) an…
techniq Jan 21, 2025
fbe437a
Use mock null data until we have better values
techniq Jan 22, 2025
8395f29
Disable motion on all chart tooltips and LineChart highlights (improv…
techniq Jan 22, 2025
d83e197
Upgrade LayerChart to 0.76.0 (legend/series integration, locking/clic…
techniq Jan 24, 2025
4673936
Hide total on baseline/current BarChart tooltip
techniq Jan 24, 2025
490d81d
Upgrade LayerChart to 0.77.0 (fix class override handling)
techniq Jan 24, 2025
bb18896
Upgrade LayerChart to 0.78.0 (expose `visibleSeries` for custom tooltip)
techniq Jan 24, 2025
8985bd8
Cleanup unused prop (now default to 1px stroke)
techniq Jan 24, 2025
cb77771
Rename `_selectedEvent` to `selectedEvent` (no longer needed to scope…
techniq Jan 24, 2025
edf6881
Setup tooltip locking with item selection
techniq Jan 24, 2025
4220c63
refactor(FeaturesLineChart): Switch to canvas rendering due to a larg…
techniq Jan 24, 2025
c04fe89
Upgrade LayerChart to 0.79.1 ( Improved canvas reactivity for all pri…
techniq Jan 25, 2025
7958050
Upgrade LayerChart to 0.79.2
techniq Jan 25, 2025
eb511c4
Improve FeaturesLineChart tooltip styling, including item hover state
techniq Jan 25, 2025
5cfb19b
Use partially transparent grid colors to not overlap spline colors
techniq Jan 27, 2025
56ac81e
Setup brush/zooming with sync between charts and top-level controls (…
techniq Jan 27, 2025
9008684
Upgrade LayerChart to 0.81.1 (Improved external brush selection display)
techniq Jan 28, 2025
904995b
Align selectSeriesKey name and type
techniq Jan 28, 2025
6b18d21
Add tooltip notice for key locking. Use ctrl key for Windows and met…
techniq Jan 28, 2025
f3bccfc
feat(PercentileLineChart): Integrate common xDomain with brushing
techniq Jan 28, 2025
9a6db31
Upgrade LayerChart to 0.81.2, fixing chart brush resuming updating `i…
techniq Jan 28, 2025
ae4f0db
feat(FeaturesLineChart): Mark selected point
techniq Jan 28, 2025
88d7059
Simplify selection state
techniq Jan 28, 2025
e1d2ae7
Remove ECharts
techniq Jan 28, 2025
1d09e62
Update package-lock.json after removing ECharts
techniq Jan 28, 2025
c80c965
feat: Setup brush/zooming on distrtibutions page
techniq Jan 28, 2025
e6a5a8c
fix: Use canvas renderContext to speed up distributions percentile li…
techniq Jan 28, 2025
d0a821d
Resolve all outstanding type errors (`npm run check`)
techniq Jan 28, 2025
304effa
Resolve all outstanding lint errors (`npm run lint`)
techniq Jan 28, 2025
07499a6
Upgrade LayerChart to 0.90.1 (integrated canvas pointer events)
techniq Jan 30, 2025
8ae2f2a
Handle null values
techniq Jan 30, 2025
44a3058
Upgrade LayerChart to 0.93.0 (integrated brush context with many inte…
techniq Feb 3, 2025
13d65e6
Update `NULL_VALUE` after change in `Constants.scala`
techniq Feb 3, 2025
31329ac
Upgrade LayerChart to 0.93.2 (fix `onpointclick` to not propagate `po…
techniq Feb 3, 2025
488863e
Upgrade LayerChart to 0.93.6 (fix flaky series point hover/click and …
techniq Feb 5, 2025
acf5dac
Upgrade LayerChart to 0.93.7 (fixes legend item clicks/filtering rese…
techniq Feb 5, 2025
a13a9ba
Upgrade LayerChart to 0.93.9 (highlight pointer cursor:pointer hover)
techniq Feb 6, 2025
53b1383
Increase padding/height of tooltip items
techniq Feb 6, 2025
1708448
Remove gap between tooltip items and increase gap between label and v…
techniq Feb 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
376 changes: 319 additions & 57 deletions frontend/package-lock.json
View file
Open in desktop

Large diffs are not rendered by default.

3 changes: 1 addition & 2 deletions frontend/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,11 +63,10 @@
"@creditkarma/thrift-server-core": "^1.0.4",
"@creditkarma/thrift-typescript": "^3.7.6",
"@layerstack/utils": "^0.0.7",
"@types/echarts": "^4.9.22",
"clsx": "^2.1.1",
"d3": "^7.9.0",
"dotenv": "^16.4.7",
"echarts": "^5.6.0",
"layerchart": "^0.93.9",
"lodash": "^4.17.21",
"tailwind-merge": "^2.6.0",
"tailwind-variants": "^0.3.0"
Expand Down
135 changes: 0 additions & 135 deletions frontend/src/lib/components/CustomEChartLegend.svelte
View file
Open in desktop

This file was deleted.

Loading