Skip to content

Splitting flaky test: AsyncKVStoreWriter #248

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 19, 2025
Merged

Splitting flaky test: AsyncKVStoreWriter #248

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion .github/workflows/test_scala_no_spark.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,6 +51,10 @@ jobs:
export SBT_OPTS="-Xmx24G -Xms4G --add-opens=java.base/sun.nio.ch=ALL-UNNAMED"
sbt "++ 2.12.18 flink/test"

- name: Run Async KV Store writer test
run: |
sbt "++ 2.12.18 flink/testOnly -- -n asyncKVStoreWriterTest"

- name: Run Aggregator tests
run: |
sbt "++ 2.12.18 aggregator/test"
Expand All @@ -61,7 +65,7 @@ jobs:

- name: Run Catalyst Util tests
run: |
sbt "++ 2.12.18 online/testOnly -- -n catalystUtilHiveUdfTest"
sbt "++ 2.12.18 online/testOnly -- -n catalystUtilHiveUdfTest"

- name: Run api tests
run: |
Expand Down
2 changes: 1 addition & 1 deletion build.sbt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -210,7 +210,7 @@ lazy val spark = project
)

lazy val flink = project
.dependsOn(aggregator.%("compile->compile;test->test"), online)
.dependsOn(aggregator.%("compile->compile;test->test"), online.%("compile->compile;test->test"))
.settings(
libraryDependencies ++= spark_all,
libraryDependencies ++= flink_all,
Expand Down
5 changes: 4 additions & 1 deletion flink/src/test/scala/ai/chronon/flink/test/AsyncKVStoreWriterTest.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,14 +4,15 @@ import ai.chronon.flink.AsyncKVStoreWriter
import ai.chronon.online.Api
import ai.chronon.online.KVStore
import ai.chronon.online.KVStore.PutRequest
import ai.chronon.online.test.TaggedFilterSuite
import org.apache.flink.api.scala._
import org.apache.flink.streaming.api.scala.DataStream
import org.apache.flink.streaming.api.scala.DataStreamUtils
import org.apache.flink.streaming.api.scala.StreamExecutionEnvironment
import org.scalatest.flatspec.AnyFlatSpec
import org.scalatestplus.mockito.MockitoSugar.mock

class AsyncKVStoreWriterTest extends AnyFlatSpec {
class AsyncKVStoreWriterTest extends AnyFlatSpec with TaggedFilterSuite {

val eventTs = 1519862400075L

Expand Down Expand Up @@ -59,4 +60,6 @@ class AsyncKVStoreWriterTest extends AnyFlatSpec {
assert(result.nonEmpty, "Expect result set to be non-empty")
assert(result.map(_.putRequest.tsMillis).forall(_.contains(eventTs)))
}

override def tagName: String = "asyncKVStoreWriterTest"
}
Loading